Bug 219466

Summary: MediaSessionHelper::setSharedHelper() hangs when "media in the GPU process" is enabled
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, ews-watchlist, glenn, peng.liu6, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
cdumez: review+, cdumez: commit-queue-
Patch for landing
none
Patch none

Jer Noble
Reported 2020-12-02 17:06:04 PST
MediaSessionHelper::setSharedHelper() hangs when "media in the GPU process" is enabled
Attachments
Patch (2.83 KB, patch)
2020-12-02 17:12 PST, Jer Noble 		cdumez: review+
cdumez: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (2.82 KB, patch)
2020-12-02 17:27 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (2.84 KB, patch)
2020-12-03 08:32 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2020-12-02 17:11:50 PST
<rdar://problem/71566601>
Jer Noble
Comment 2 2020-12-02 17:12:13 PST
Created attachment 415265 [details] Patch
Chris Dumez
Comment 3 2020-12-02 17:14:06 PST
Comment on attachment 415265 [details] Patch r=me
Chris Dumez
Comment 4 2020-12-02 17:15:05 PST
Comment on attachment 415265 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415265&action=review > Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:147 > + sharedHelperInstance() = std::make_unique<MediaSessionHelperiOS>(); makeUnique<> is the new way iirc.
Chris Dumez
Comment 5 2020-12-02 17:15:10 PST
Comment on attachment 415265 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415265&action=review > Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:147 > + sharedHelperInstance() = std::make_unique<MediaSessionHelperiOS>(); makeUnique<> is the new way iirc.
Jer Noble
Comment 6 2020-12-02 17:27:19 PST
Created attachment 415266 [details] Patch for landing
Chris Dumez
Comment 7 2020-12-03 08:32:35 PST
Created attachment 415302 [details] Patch
EWS
Comment 8 2020-12-03 09:16:08 PST
Committed r270394: <https://trac.webkit.org/changeset/270394> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415302 [details].
Note You need to log in before you can comment on or make changes to this bug.