Bug 219417

Summary:

[GPU Process] Disconnect NativeImages from RemoteResourceCacheProxy when RemoteRenderingBackendProxy is destroyed

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

Layout and Rendering

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, simon.fraser, thorton, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Said Abou-Hallawa 2020-12-01 18:05:01 PST

This is a timing issue which may cause crash if deleting RemoteRenderingBackendProxy happens before deleting the NativeImages maintained by its RemoteResourceCacheProxy.

Comment 1 Said Abou-Hallawa 2020-12-01 18:29:54 PST

Created attachment 415184 [details]
Patch

Comment 2 Tim Horton 2020-12-01 23:54:56 PST

Comment on attachment 415184 [details]
Patch

I guess my next question is ... can't a NativeImage be used between RemoteResourceCacheProxy instances?? (if you have two pages in one Web Content process). Or is NativeImage somehow scoped in such a way that that is not possible?

Comment 3 Said Abou-Hallawa 2020-12-03 14:02:55 PST

Created attachment 415342 [details]
Patch

Comment 4 EWS 2020-12-03 16:24:53 PST

Committed r270417: <https://trac.webkit.org/changeset/270417>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415342 [details].

Comment 5 Radar WebKit Bug Importer 2020-12-03 16:25:17 PST

<rdar://problem/71957568>