Bug 219330

Summary: [LFC][IFC] Remove LineBuilder::availableWidth
Product: WebKit Reporter: alan baradlay <zalan>
Component: Layout and RenderingAssignee: alan baradlay <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, sam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan baradlay
Reported 2020-11-28 17:04:48 PST
there is no "global" available width. it should be recomputed whenever we add a new inline level box to accommodate for intrusive floats.
Attachments
Patch (6.02 KB, patch)
2020-11-28 17:10 PST, alan baradlay 		no flags
DetailsFormatted DiffDiff
Patch (6.06 KB, patch)
2020-11-28 19:49 PST, alan baradlay 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan baradlay
Comment 1 2020-11-28 17:10:27 PST
Created attachment 414982 [details] Patch
Sam Weinig
Comment 2 2020-11-28 17:13:33 PST
Comment on attachment 414982 [details] Patch Is this observable? Can this be tested / is this tested already?
alan baradlay
Comment 3 2020-11-28 19:49:01 PST
Created attachment 414984 [details] Patch
alan baradlay
Comment 4 2020-11-29 10:43:40 PST
(In reply to Sam Weinig from comment #2) > Comment on attachment 414982 [details] > Patch > > Is this observable? Can this be tested / is this tested already? Not yet, this is in preparation for supporting cases when the inline level box stretches the line vertically and we need to check if floats are in the way (so the line may have different available space values depending on the current line height).
EWS
Comment 5 2020-11-29 11:10:23 PST
Committed r270228: <https://trac.webkit.org/changeset/270228> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414984 [details].
Radar WebKit Bug Importer
Comment 6 2020-11-29 11:11:20 PST
<rdar://problem/71787245>
Note You need to log in before you can comment on or make changes to this bug.