Bug 21932

Summary: Add non-pointer symbol lookups to SoftLinking.h
Product: WebKit Reporter: Greg Bolsinga <bolsinga>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
looks up non pointer symbols
darin: review+
changed SYMBOL to DATA none

Greg Bolsinga
Reported 2008-10-28 13:47:47 PDT
It can currently look up pointers, but not symbols that aren't pointers.
Attachments
looks up non pointer symbols (1.38 KB, patch)
2008-10-28 13:49 PDT, Greg Bolsinga 		darin: review+
DetailsFormatted DiffDiff
changed SYMBOL to DATA (1.37 KB, patch)
2008-10-28 14:33 PDT, Greg Bolsinga 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Greg Bolsinga
Comment 1 2008-10-28 13:49:35 PDT
Created attachment 24728 [details] looks up non pointer symbols This is needed for some other platform work.
Darin Adler
Comment 2 2008-10-28 13:54:28 PDT
Comment on attachment 24728 [details] looks up non pointer symbols The change seems fine. But I'm not sure "SYMBOL" is a good name for this. They're all symbols. Maybe "OBJECT"? r=me as-is, but please consider other names
Greg Bolsinga
Comment 3 2008-10-28 14:28:31 PDT
How about DATA, as I'm using this to get data constants?
Greg Bolsinga
Comment 4 2008-10-28 14:33:11 PDT
Created attachment 24730 [details] changed SYMBOL to DATA Same as before, but SYMBOL is not DATA
David Kilzer (:ddkilzer)
Comment 5 2008-10-28 14:37:22 PDT
(In reply to comment #3) > How about DATA, as I'm using this to get data constants? CONSTANT might work better.
David Kilzer (:ddkilzer)
Comment 6 2008-10-28 14:43:23 PDT
$ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/mac/SoftLinking.h Committed r37941 Changed SYMBOL/DATA to CONSTANT when landing. http://trac.webkit.org/changeset/37941
Note You need to log in before you can comment on or make changes to this bug.