Summary: | Add non-pointer symbol lookups to SoftLinking.h | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Greg Bolsinga <bolsinga> | ||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ddkilzer | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Greg Bolsinga
2008-10-28 13:47:47 PDT
Created attachment 24728 [details]
looks up non pointer symbols
This is needed for some other platform work.
Comment on attachment 24728 [details]
looks up non pointer symbols
The change seems fine. But I'm not sure "SYMBOL" is a good name for this. They're all symbols. Maybe "OBJECT"?
r=me as-is, but please consider other names
How about DATA, as I'm using this to get data constants? Created attachment 24730 [details]
changed SYMBOL to DATA
Same as before, but SYMBOL is not DATA
(In reply to comment #3) > How about DATA, as I'm using this to get data constants? CONSTANT might work better. $ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/mac/SoftLinking.h Committed r37941 Changed SYMBOL/DATA to CONSTANT when landing. http://trac.webkit.org/changeset/37941 |