Bug 219310

Summary: [LFC Display] Fix box locations for positioned elements
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=219322
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch zalan: review+, ews-feeder: commit-queue-

Description Simon Fraser (smfr) 2020-11-27 10:20:22 PST
[LFC Display] Fix box locations for positioned elements
Comment 1 Simon Fraser (smfr) 2020-11-27 10:20:36 PST
Created attachment 414953 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-11-27 11:28:29 PST
Created attachment 414960 [details]
Patch
Comment 3 zalan 2020-11-27 14:26:37 PST
Comment on attachment 414960 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414960&action=review

> Source/WebCore/layout/layouttree/LayoutBox.h:233
> +    return isInitialContainingBlock() || isPositioned() || style().hasTransform();

I'd change it to return isPositioned() || isContainingBlockForFixedPosition(); -which makes it quite clear that fixed positioning is a type of out-of-flow.
Comment 4 Simon Fraser (smfr) 2020-11-27 18:32:26 PST
https://trac.webkit.org/changeset/270209/webkit
Comment 5 Radar WebKit Bug Importer 2020-11-27 18:33:15 PST
<rdar://problem/71769575>