Bug 219299

Summary: [ANGLE] Convert adjust-angle-include-paths.sh to a Python script for Windows without Cygwin
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: ANGLEAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, dino, ews-watchlist, graouts, gyuyoung.kim, kbr, kkinnunen, kondapallykalyan, krollin, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Fujii Hironori 2020-11-26 20:33:05 PST
[ANGLE] Convert adjust-angle-include-paths.sh to a Python script for Cygwin-free Windows
Comment 1 Fujii Hironori 2020-11-26 20:39:34 PST
Created attachment 414913 [details]
Patch
Comment 2 EWS Watchlist 2020-11-26 20:40:20 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kenneth Russell 2020-11-27 18:13:14 PST
Comment on attachment 414913 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414913&action=review

Looks fine with one piece of feedback on the copyright. r+

> Source/ThirdParty/ANGLE/adjust-angle-include-paths.py:3
> +# Copyright (C) 2020 Sony Interactive Entertainment Inc.

I'm not sure how appropriate it is to put Sony's copyright on this script, with no license, given that it's a port of a script written by myself and others which previously didn't have one. May I suggest either removing this, or putting the full WebKit copyright stanza and adding all of the contributor companies (Google, Apple, Igalia, and now Sony)?
Comment 4 Fujii Hironori 2020-11-27 18:48:47 PST
Comment on attachment 414913 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414913&action=review

Thank you for the review.

>> Source/ThirdParty/ANGLE/adjust-angle-include-paths.py:3
>> +# Copyright (C) 2020 Sony Interactive Entertainment Inc.
> 
> I'm not sure how appropriate it is to put Sony's copyright on this script, with no license, given that it's a port of a script written by myself and others which previously didn't have one. May I suggest either removing this, or putting the full WebKit copyright stanza and adding all of the contributor companies (Google, Apple, Igalia, and now Sony)?

Ok, I'll remove it.
Comment 5 Fujii Hironori 2020-11-27 19:04:12 PST
Created attachment 414972 [details]
Patch for landing
Comment 6 EWS 2020-11-27 19:57:14 PST
Committed r270212: <https://trac.webkit.org/changeset/270212>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414972 [details].
Comment 7 Radar WebKit Bug Importer 2020-11-27 19:58:16 PST
<rdar://problem/71770193>