Bug 219299

Summary: [ANGLE] Convert adjust-angle-include-paths.sh to a Python script for Windows without Cygwin
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: ANGLEAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, dino, ews-watchlist, graouts, gyuyoung.kim, kbr, kkinnunen, kondapallykalyan, krollin, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Fujii Hironori
Reported 2020-11-26 20:33:05 PST
[ANGLE] Convert adjust-angle-include-paths.sh to a Python script for Cygwin-free Windows
Attachments
Patch (7.96 KB, patch)
2020-11-26 20:39 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.95 KB, patch)
2020-11-27 19:04 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-11-26 20:39:34 PST
Created attachment 414913 [details] Patch
EWS Watchlist
Comment 2 2020-11-26 20:40:20 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 3 2020-11-27 18:13:14 PST
Comment on attachment 414913 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414913&action=review Looks fine with one piece of feedback on the copyright. r+ > Source/ThirdParty/ANGLE/adjust-angle-include-paths.py:3 > +# Copyright (C) 2020 Sony Interactive Entertainment Inc. I'm not sure how appropriate it is to put Sony's copyright on this script, with no license, given that it's a port of a script written by myself and others which previously didn't have one. May I suggest either removing this, or putting the full WebKit copyright stanza and adding all of the contributor companies (Google, Apple, Igalia, and now Sony)?
Fujii Hironori
Comment 4 2020-11-27 18:48:47 PST
Comment on attachment 414913 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414913&action=review Thank you for the review. >> Source/ThirdParty/ANGLE/adjust-angle-include-paths.py:3 >> +# Copyright (C) 2020 Sony Interactive Entertainment Inc. > > I'm not sure how appropriate it is to put Sony's copyright on this script, with no license, given that it's a port of a script written by myself and others which previously didn't have one. May I suggest either removing this, or putting the full WebKit copyright stanza and adding all of the contributor companies (Google, Apple, Igalia, and now Sony)? Ok, I'll remove it.
Fujii Hironori
Comment 5 2020-11-27 19:04:12 PST
Created attachment 414972 [details] Patch for landing
EWS
Comment 6 2020-11-27 19:57:14 PST
Committed r270212: <https://trac.webkit.org/changeset/270212> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414972 [details].
Radar WebKit Bug Importer
Comment 7 2020-11-27 19:58:16 PST
<rdar://problem/71770193>
Note You need to log in before you can comment on or make changes to this bug.