Summary: | Reflect.preventExtensions should not throw if called on WindowProxy or Location | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> | ||||||
Component: | DOM | Assignee: | Alexey Shvayka <ashvayka> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Minor | CC: | cdumez, clopez, darin, ews-watchlist, ggaren, rniwa, sam, webkit-bug-importer, youennf, ysuzuki | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=161554 https://github.com/web-platform-tests/wpt/pull/26762 |
||||||||
Attachments: |
|
Description
Alexey Shvayka
2020-11-23 21:10:05 PST
Created attachment 414822 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Comment on attachment 414822 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414822&action=review Can you check test failures? > LayoutTests/imported/w3c/ChangeLog:13 > + * web-platform-tests/html/browsers/history/the-location-interface/location-prevent-extensions-expected.txt: Added. > + * web-platform-tests/html/browsers/history/the-location-interface/location-prevent-extensions.html: Added. > + * web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt: > + * web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html: > + * web-platform-tests/html/browsers/the-windowproxy-exotic-object/windowproxy-prevent-extensions-expected.txt: Added. > + * web-platform-tests/html/browsers/the-windowproxy-exotic-object/windowproxy-prevent-extensions.html: Added. Are they imported tests from WPT via import-w3c-tests? If it is not, can you put them under http/wpt/? LayoutTests/imported is only for imported tests. (In reply to Yusuke Suzuki from comment #4) > Can you check test failures? Failures are caused by error message change; will adjust soon. > Are they imported tests from WPT via import-w3c-tests? If it is not, can you > put them under http/wpt/? LayoutTests/imported is only for imported tests. These tests are new (not imported). I am putting them to LayoutTests/imported to leverage the WPT export process (https://trac.webkit.org/wiki/WPTExportProcess): once the patch is reviewed, I can land a WPT PR with those tests w/o additional review on GitHub (which saves a lot of time and lets us share the tests that Blink currently fails), and only then I would land the patch itself. Created attachment 415444 [details]
Patch
Adjust expectations for error message change.
Committed r270702: <https://trac.webkit.org/changeset/270702> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415444 [details]. |