Bug 219230

Summary: [LFC][Integration] LayoutIntegration::Line::rect is way too ambiguous
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

zalan
Reported 2020-11-20 16:27:54 PST
let's use lineBox* helpers instead
Attachments
Patch (11.43 KB, patch)
2020-11-20 16:31 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (11.43 KB, patch)
2020-11-21 06:13 PST, zalan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2020-11-20 16:31:17 PST
Created attachment 414744 [details] Patch
Antti Koivisto
Comment 2 2020-11-20 22:23:11 PST
Comment on attachment 414744 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414744&action=review > Source/WebCore/layout/integration/LayoutIntegrationLineIteratorModernPath.h:62 > - LayoutUnit lineBoxTop() const { return LayoutUnit::fromFloatRound(line().rect().y()); } > - LayoutUnit lineBoxBottom() const { return LayoutUnit::fromFloatRound(line().rect().maxY()); } > + LayoutUnit lineBoxTop() const { return LayoutUnit::fromFloatRound(line().lineBoxTop()); } > + LayoutUnit lineBoxBottom() const { return LayoutUnit::fromFloatRound(line().lineBoxBottom()); } > > // FIXME: What should these really be? > LayoutUnit selectionTop() const { return top(); } > LayoutUnit selectionTopForHitTesting() const { return top(); } > LayoutUnit selectionBottom() const { return bottom(); } > > - float contentLogicalLeft() const { return line().rect().x() + line().contentLeftOffset(); } > + float contentLogicalLeft() const { return line().lineBoxLeft() + line().contentLeftOffset(); } Much better!
zalan
Comment 3 2020-11-21 06:13:59 PST
Created attachment 414760 [details] Patch
EWS
Comment 4 2020-11-21 07:15:43 PST
Committed r270146: <https://trac.webkit.org/changeset/270146> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414760 [details].
Radar WebKit Bug Importer
Comment 5 2020-11-21 07:16:18 PST
<rdar://problem/71655183>
Note You need to log in before you can comment on or make changes to this bug.