Bug 219220

Summary: [LFC][Integration] Add contentOffset and contentWidth to Line
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

alan
Reported 2020-11-20 13:06:32 PST
This helps to match the legacy root inline box geometry.
Attachments
Patch (14.61 KB, patch)
2020-11-20 13:12 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (14.78 KB, patch)
2020-11-20 14:02 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (14.81 KB, patch)
2020-11-20 15:44 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (14.82 KB, patch)
2020-11-20 15:54 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2020-11-20 13:12:23 PST
Created attachment 414709 [details] Patch
alan
Comment 2 2020-11-20 14:02:40 PST
Created attachment 414719 [details] Patch
alan
Comment 3 2020-11-20 15:44:47 PST
Created attachment 414738 [details] Patch
alan
Comment 4 2020-11-20 15:54:09 PST
Created attachment 414739 [details] Patch
Antti Koivisto
Comment 5 2020-11-20 22:20:18 PST
Comment on attachment 414739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414739&action=review > Source/WebCore/layout/integration/LayoutIntegrationLine.h:53 > + , m_contentLeftOffset(contentLeftOffset) > + , m_contentWidth(contentWidth) Could the client just do content.runs[line.firstRunIndex()].rect().x() etc to get the same numbers? I guess having a redundant copy here doesn't hurt.
EWS
Comment 6 2020-11-21 04:57:09 PST
Committed r270143: <https://trac.webkit.org/changeset/270143> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414739 [details].
Radar WebKit Bug Importer
Comment 7 2020-11-21 04:58:16 PST
<rdar://problem/71654468>
Note You need to log in before you can comment on or make changes to this bug.