Bug 219164

Summary: [LFC][Integration] Remove ensureLineBoxes call from RenderedPosition constructor
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, bfulgham, cdumez, cfleizach, dmazzoni, esprehn+autocc, ews-watchlist, jcraig, jdiggs, kangil.han, mifenton, samuel_white, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 219197, 219233    
Bug Blocks:    
Attachments:
Description Flags
patch
ews-feeder: commit-queue-
patch
zalan: review+, ews-feeder: commit-queue-
patch
none
patch ews-feeder: commit-queue-

Description Antti Koivisto 2020-11-19 08:38:47 PST 
It is not needed anymore.
Comment 1 Antti Koivisto 2020-11-19 08:42:21 PST 
Created attachment 414585 [details]
patch
Comment 2 Antti Koivisto 2020-11-20 07:30:12 PST 
Created attachment 414673 [details]
patch
Comment 3 zalan 2020-11-20 07:34:52 PST 
Comment on attachment 414673 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414673&action=review

> Source/WebCore/dom/Position.cpp:-1378
> -void Position::ensureLineBoxes() const
> -{
> -    auto node = deprecatedNode();
> -    if (!node)
> -        return;
> -    auto renderer = node->renderer();
> -    if (!renderer)
> -        return;
> -    auto* parent = renderer->parent();
> -    if (is<RenderBlockFlow>(parent))
> -        downcast<RenderBlockFlow>(*parent).ensureLineBoxes();
> -}
> -

Nice!
Comment 4 Antti Koivisto 2020-11-21 09:48:07 PST 
Created attachment 414762 [details]
patch
Comment 5 Antti Koivisto 2020-11-21 10:01:01 PST 
Created attachment 414764 [details]
patch
Comment 6 EWS 2020-11-21 11:43:35 PST 
Committed r270150: <https://trac.webkit.org/changeset/270150>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414764 [details].
Comment 7 Radar WebKit Bug Importer 2020-11-21 11:44:16 PST 
<rdar://problem/71657035>