Bug 219164

Summary: [LFC][Integration] Remove ensureLineBoxes call from RenderedPosition constructor
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, bfulgham, cdumez, cfleizach, dmazzoni, esprehn+autocc, ews-watchlist, jcraig, jdiggs, kangil.han, mifenton, samuel_white, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 219197, 219233    
Bug Blocks:    
Attachments:
Description Flags
patch
ews-feeder: commit-queue-
patch
zalan: review+, ews-feeder: commit-queue-
patch
none
patch ews-feeder: commit-queue-

Antti Koivisto
Reported 2020-11-19 08:38:47 PST
It is not needed anymore.
Attachments
patch (3.42 KB, patch)
2020-11-19 08:42 PST, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch (4.75 KB, patch)
2020-11-20 07:30 PST, Antti Koivisto 		zalan: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch (6.13 KB, patch)
2020-11-21 09:48 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (6.13 KB, patch)
2020-11-21 10:01 PST, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2020-11-19 08:42:21 PST
Created attachment 414585 [details] patch
Antti Koivisto
Comment 2 2020-11-20 07:30:12 PST
Created attachment 414673 [details] patch
zalan
Comment 3 2020-11-20 07:34:52 PST
Comment on attachment 414673 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=414673&action=review > Source/WebCore/dom/Position.cpp:-1378 > -void Position::ensureLineBoxes() const > -{ > - auto node = deprecatedNode(); > - if (!node) > - return; > - auto renderer = node->renderer(); > - if (!renderer) > - return; > - auto* parent = renderer->parent(); > - if (is<RenderBlockFlow>(parent)) > - downcast<RenderBlockFlow>(*parent).ensureLineBoxes(); > -} > - Nice!
Antti Koivisto
Comment 4 2020-11-21 09:48:07 PST
Created attachment 414762 [details] patch
Antti Koivisto
Comment 5 2020-11-21 10:01:01 PST
Created attachment 414764 [details] patch
EWS
Comment 6 2020-11-21 11:43:35 PST
Committed r270150: <https://trac.webkit.org/changeset/270150> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414764 [details].
Radar WebKit Bug Importer
Comment 7 2020-11-21 11:44:16 PST
<rdar://problem/71657035>
Note You need to log in before you can comment on or make changes to this bug.