Bug 219160

Summary: [GTK] Migrate WebKitTestServer to libsoup 2.48 API
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: Tools / TestsAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: REOPENED ---    
Severity: Normal CC: cgarcia, commit-queue, mcatanzaro, pgriffis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=146109
Bug Depends on: 220922    
Bug Blocks: 219257    
Attachments:
Description Flags
Untested patch
none
Untested patch
none
Untested patch
cgarcia: review+
Patch none

Description Frédéric Wang (:fredw) 2020-11-19 07:15:42 PST
Created attachment 414575 [details]
Untested patch

It seems our WebDriver code uses the new soup_server_listen APIs from 2.48, so the code added in bug 146165 is no longer correct, we should really require 2.48 or higher.
Comment 1 Frédéric Wang (:fredw) 2020-11-19 07:16:25 PST
Created attachment 414576 [details]
Untested patch
Comment 2 Frédéric Wang (:fredw) 2020-11-19 07:17:07 PST
Created attachment 414577 [details]
Untested patch
Comment 3 Frédéric Wang (:fredw) 2020-11-19 09:52:16 PST
Comment on attachment 414577 [details]
Untested patch

Please take a look.

Disclaimer: I haven't use glib for a long time, hopefully I haven't misused the API.
Comment 4 Frédéric Wang (:fredw) 2020-11-20 00:54:40 PST
Created attachment 414660 [details]
Patch
Comment 5 EWS 2020-11-20 01:40:37 PST
Committed r270074: <https://trac.webkit.org/changeset/270074>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414660 [details].
Comment 6 Radar WebKit Bug Importer 2020-11-20 01:41:16 PST
<rdar://problem/71620310>
Comment 7 WebKit Commit Bot 2021-01-25 07:06:46 PST
Re-opened since this is blocked by bug 220922