Bug 219116

Summary:

'run-analysis' script should schedule retries for A/B tests even after analysis chart failure.

Product:

WebKit

Reporter:

dewei_zhu

Component:

New Bugs

Assignee:

dewei_zhu

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dewei_zhu, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	rniwa: review+

Description dewei_zhu 2020-11-18 14:51:05 PST

'run-analysis' script should schedule retries for A/B tests even after analysis failure.

Comment 1 dewei_zhu 2020-11-18 14:57:31 PST

Created attachment 414488 [details]
Patch

Comment 2 Ryosuke Niwa 2020-11-18 17:54:10 PST

Comment on attachment 414488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414488&action=review

> Websites/perf.webkit.org/tools/run-analysis.js:50
> +        console.error(`Failed analyze measurement sets due to ${error}`);

Failed *to* analyze

> Websites/perf.webkit.org/tools/run-analysis.js:66
> +        console.error(`Failed retry for test group due to ${error}`);

Failed *to retry test groups* due to

Comment 3 dewei_zhu 2020-11-20 17:27:51 PST

Change is landed in r270140.