Bug 219111

Summary: Remove IRC bots from webkitpy
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, jbedard, lingho, webkit-bot-watchers-bugzilla, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch jbedard: review+

Alexey Proskuryakov
Reported 2020-11-18 13:46:10 PST
We haven't been running any IRC bots for a while, this is dead code.
Attachments
proposed patch (164.49 KB, patch)
2020-11-18 13:50 PST, Alexey Proskuryakov 		jbedard: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2020-11-18 13:50:10 PST
Created attachment 414482 [details] proposed patch
Alexey Proskuryakov
Comment 2 2020-11-18 16:05:03 PST
svn-apply cannot process directory removal, but this is still up for review. What can go wrong without EWS? :)
Jonathan Bedard
Comment 3 2020-11-18 16:20:06 PST
(In reply to Alexey Proskuryakov from comment #2) > svn-apply cannot process directory removal, but this is still up for review. > What can go wrong without EWS? :) I assume you're run test-webkitpy...that's the one that would break, if anything was going to.
Jonathan Bedard
Comment 4 2020-11-18 16:25:08 PST
Comment on attachment 414482 [details] proposed patch Looks good, assuming webkitpy tests pass. If we wanted to feel better about EWS, a patch that does not remove third party/irc would still remove the code that we have historically owned, and might have a better chance of applying.
Aakash Jain
Comment 5 2020-11-18 16:27:16 PST
Looks good. We can also consider removing all instances of 'sheriff-bot' from webkitpy (e.g.: tool/commands/download.py, common/config/contributors.json)
Alexey Proskuryakov
Comment 6 2020-11-18 17:32:29 PST
(In reply to Aakash Jain from comment #5) > Looks good. We can also consider removing all instances of 'sheriff-bot' > from webkitpy (e.g.: tool/commands/download.py, > common/config/contributors.json) It's also mentioned in Tools/WebKitBot/src/WebKitBot.mjs, so I wasn't sure how to confirm that it's OK to remove.
Alexey Proskuryakov
Comment 7 2020-11-18 17:36:17 PST
But I'm fairly sure that what I'm removing is unused. CC'ing bot watchers in case I do break the Slack bot somehow.
Alexey Proskuryakov
Comment 8 2020-11-18 17:38:26 PST
Committed http://trac.webkit.org/r270003
Radar WebKit Bug Importer
Comment 9 2020-11-18 17:39:27 PST
<rdar://problem/71564617>
Note You need to log in before you can comment on or make changes to this bug.