|Summary:||Remove IRC bots from webkitpy|
|Product:||WebKit||Reporter:||Alexey Proskuryakov <ap>|
|Component:||Tools / Tests||Assignee:||Alexey Proskuryakov <ap>|
|Severity:||Normal||CC:||aakash_jain, jbedard, lingho, webkit-bot-watchers-bugzilla, webkit-bug-importer, ysuzuki|
Description Alexey Proskuryakov 2020-11-18 13:46:10 PST
We haven't been running any IRC bots for a while, this is dead code.
Comment 1 Alexey Proskuryakov 2020-11-18 13:50:10 PST
Created attachment 414482 [details] proposed patch
Comment 2 Alexey Proskuryakov 2020-11-18 16:05:03 PST
svn-apply cannot process directory removal, but this is still up for review. What can go wrong without EWS? :)
Comment 3 Jonathan Bedard 2020-11-18 16:20:06 PST
(In reply to Alexey Proskuryakov from comment #2) > svn-apply cannot process directory removal, but this is still up for review. > What can go wrong without EWS? :) I assume you're run test-webkitpy...that's the one that would break, if anything was going to.
Comment 4 Jonathan Bedard 2020-11-18 16:25:08 PST
Comment on attachment 414482 [details] proposed patch Looks good, assuming webkitpy tests pass. If we wanted to feel better about EWS, a patch that does not remove third party/irc would still remove the code that we have historically owned, and might have a better chance of applying.
Comment 5 Aakash Jain 2020-11-18 16:27:16 PST
Looks good. We can also consider removing all instances of 'sheriff-bot' from webkitpy (e.g.: tool/commands/download.py, common/config/contributors.json)
Comment 6 Alexey Proskuryakov 2020-11-18 17:32:29 PST
(In reply to Aakash Jain from comment #5) > Looks good. We can also consider removing all instances of 'sheriff-bot' > from webkitpy (e.g.: tool/commands/download.py, > common/config/contributors.json) It's also mentioned in Tools/WebKitBot/src/WebKitBot.mjs, so I wasn't sure how to confirm that it's OK to remove.
Comment 7 Alexey Proskuryakov 2020-11-18 17:36:17 PST
But I'm fairly sure that what I'm removing is unused. CC'ing bot watchers in case I do break the Slack bot somehow.