| Summary: | Remove IRC bots from webkitpy | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
| Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, jbedard, lingho, webkit-bot-watchers-bugzilla, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alexey Proskuryakov
2020-11-18 13:46:10 PST
Created attachment 414482 [details]
proposed patch
svn-apply cannot process directory removal, but this is still up for review. What can go wrong without EWS? :) (In reply to Alexey Proskuryakov from comment #2) > svn-apply cannot process directory removal, but this is still up for review. > What can go wrong without EWS? :) I assume you're run test-webkitpy...that's the one that would break, if anything was going to. Comment on attachment 414482 [details]
proposed patch
Looks good, assuming webkitpy tests pass.
If we wanted to feel better about EWS, a patch that does not remove third party/irc would still remove the code that we have historically owned, and might have a better chance of applying.
Looks good. We can also consider removing all instances of 'sheriff-bot' from webkitpy (e.g.: tool/commands/download.py, common/config/contributors.json) (In reply to Aakash Jain from comment #5) > Looks good. We can also consider removing all instances of 'sheriff-bot' > from webkitpy (e.g.: tool/commands/download.py, > common/config/contributors.json) It's also mentioned in Tools/WebKitBot/src/WebKitBot.mjs, so I wasn't sure how to confirm that it's OK to remove. But I'm fairly sure that what I'm removing is unused. CC'ing bot watchers in case I do break the Slack bot somehow. Committed http://trac.webkit.org/r270003 |