Bug 219103

Summary: [iOS][FCR] Add new look for meter element
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: FormsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, pdr, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: iPhone / iPad   
OS: Unspecified   
Bug Depends on: 219046    
Bug Blocks:    
Attachments:
Description Flags
Patch
wenson_hsieh: review+
Patch for landing none

Aditya Keerthi
Reported 2020-11-18 11:51:58 PST
...
Attachments
Patch (19.71 KB, patch)
2020-11-18 11:55 PST, Aditya Keerthi 		wenson_hsieh: review+
DetailsFormatted DiffDiff
Patch for landing (19.68 KB, patch)
2020-11-27 09:08 PST, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2020-11-18 11:52:14 PST
<rdar://problem/71549155>
Aditya Keerthi
Comment 2 2020-11-18 11:55:14 PST
Created attachment 414465 [details] Patch
Aditya Keerthi
Comment 3 2020-11-18 11:58:27 PST
Patch will apply once https://bugs.webkit.org/show_bug.cgi?id=219046 has landed.
Wenson Hsieh
Comment 4 2020-11-20 13:23:41 PST
Comment on attachment 414465 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414465&action=review > Source/WebCore/rendering/RenderThemeIOS.mm:2092 > + auto* element = renderMeter.meterElement(); Nit - I /think/ we prefer RefPtr over raw pointers like this in new code (i.e. auto element = makeRefPtr(renderMeter.meterElement());)
Aditya Keerthi
Comment 5 2020-11-27 09:08:04 PST
Created attachment 414949 [details] Patch for landing
EWS
Comment 6 2020-11-27 13:32:21 PST
Committed r270207: <https://trac.webkit.org/changeset/270207> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414949 [details].
Note You need to log in before you can comment on or make changes to this bug.