| Summary: | Use final in generated wrapper owner code | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||||
| Component: | Bindings | Assignee: | Don Olmstead <don.olmstead> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | alecflett, beidson, cdumez, ews-watchlist, jsbell, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Don Olmstead
2020-11-18 10:56:23 PST
Created attachment 414463 [details]
Patch
Comment on attachment 414463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414463&action=review r=me with one suggestion. > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3230 > push(@headerContent, "public:\n"); How about making `class ${exportMacro}JS${interfaceName}Owner` final too? I don't think anyone is inheriting this class. (In reply to Yusuke Suzuki from comment #2) > Comment on attachment 414463 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414463&action=review > > r=me with one suggestion. > > > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3230 > > push(@headerContent, "public:\n"); > > How about making `class ${exportMacro}JS${interfaceName}Owner` final too? I > don't think anyone is inheriting this class. I'm going to split this patch into two parts since there was a bit more surgery required to accommodate this change. Created attachment 414594 [details]
Patch
Created attachment 414598 [details]
Patch
Committed r270042: <https://trac.webkit.org/changeset/270042> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414598 [details]. |