Bug 219098

Summary: Use final in generated wrapper owner code
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: BindingsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, cdumez, ews-watchlist, jsbell, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ysuzuki: review+
Patch
none
Patch none

Description Don Olmstead 2020-11-18 10:56:23 PST
Generated bindings should use override when appropriate.
Comment 1 Don Olmstead 2020-11-18 11:33:49 PST
Created attachment 414463 [details]
Patch
Comment 2 Yusuke Suzuki 2020-11-18 15:42:26 PST
Comment on attachment 414463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414463&action=review

r=me with one suggestion.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3230
>          push(@headerContent, "public:\n");

How about making `class ${exportMacro}JS${interfaceName}Owner` final too? I don't think anyone is inheriting this class.
Comment 3 Don Olmstead 2020-11-19 08:42:51 PST
(In reply to Yusuke Suzuki from comment #2)
> Comment on attachment 414463 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414463&action=review
> 
> r=me with one suggestion.
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3230
> >          push(@headerContent, "public:\n");
> 
> How about making `class ${exportMacro}JS${interfaceName}Owner` final too? I
> don't think anyone is inheriting this class.

I'm going to split this patch into two parts since there was a bit more surgery required to accommodate this change.
Comment 4 Don Olmstead 2020-11-19 09:45:19 PST Comment hidden (obsolete)
Comment 5 Don Olmstead 2020-11-19 10:07:00 PST
Created attachment 414598 [details]
Patch
Comment 6 EWS 2020-11-19 12:01:06 PST
Committed r270042: <https://trac.webkit.org/changeset/270042>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414598 [details].
Comment 7 Radar WebKit Bug Importer 2020-11-19 12:02:18 PST
<rdar://problem/71596160>