Bug 219095

Summary: Big Sur testers failing to download build products
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Tools / TestsAssignee: Matt Lewis <jlewis3>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, jlewis3, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Ryan Haddad
Reported 2020-11-18 10:25:08 PST
Big Sur testers failing to download build products python ./Tools/CISupport/download-built-product --platform=mac --release 'https://s3-us-west-2.amazonaws.com/archives.webkit.org/mac-bigsur-x86_64 arm64-release/269963.zip' ... ... % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 curl: (22) The requested URL returned error: 505 HTTP Version not supported https://build.webkit.org/builders/Apple-BigSur-Release-WK2-Tests/builds/44
Attachments
Patch (2.13 KB, patch)
2020-11-18 12:32 PST, Matt Lewis 		no flags
DetailsFormatted DiffDiff
Patch (2.14 KB, patch)
2020-11-18 12:35 PST, Matt Lewis 		no flags
DetailsFormatted DiffDiff
Patch (2.73 KB, patch)
2020-11-18 13:04 PST, Matt Lewis 		no flags
DetailsFormatted DiffDiff
Patch (2.85 KB, patch)
2020-11-18 13:15 PST, Matt Lewis 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.85 KB, patch)
2020-11-18 13:43 PST, Matt Lewis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-11-18 10:25:26 PST
<rdar://problem/71545314>
Matt Lewis
Comment 2 2020-11-18 12:30:26 PST
Looks like this is due to the space in the URL. Not sure how we archived the build product with a space, but we can fix it with a '+' in place of the space.
Matt Lewis
Comment 3 2020-11-18 12:32:52 PST
Created attachment 414468 [details] Patch
Matt Lewis
Comment 4 2020-11-18 12:35:30 PST
Created attachment 414469 [details] Patch
Matt Lewis
Comment 5 2020-11-18 12:36:04 PST
re-uploaded for copyright fix
Matt Lewis
Comment 6 2020-11-18 13:04:05 PST
Created attachment 414474 [details] Patch
Matt Lewis
Comment 7 2020-11-18 13:04:56 PST
At the request offline. Added python3 support. Also both quote and quote_plus work.
Aakash Jain
Comment 8 2020-11-18 13:10:24 PST
Comment on attachment 414474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414474&action=review > Tools/CISupport/download-built-product:32 > +try: Instead of try except, it might be a good idea to use sys.version_info like: https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/system/path.py#L39
Matt Lewis
Comment 9 2020-11-18 13:15:01 PST
Created attachment 414475 [details] Patch
Aakash Jain
Comment 10 2020-11-18 13:19:06 PST
Comment on attachment 414475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414475&action=review > Tools/CISupport/download-built-product:3 > +# Copyright (C) 2009,2020 Apple Inc. All rights reserved. Nit: missing space after comma.
Matt Lewis
Comment 11 2020-11-18 13:43:08 PST
Created attachment 414480 [details] Patch for landing
EWS
Comment 12 2020-11-18 14:42:03 PST
Committed r269988: <https://trac.webkit.org/changeset/269988> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414480 [details].
Note You need to log in before you can comment on or make changes to this bug.