Bug 219095

Summary: Big Sur testers failing to download build products
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Tools / TestsAssignee: Matt Lewis <jlewis3>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, jlewis3, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Description Ryan Haddad 2020-11-18 10:25:08 PST 
Big Sur testers failing to download build products

python ./Tools/CISupport/download-built-product --platform=mac --release 'https://s3-us-west-2.amazonaws.com/archives.webkit.org/mac-bigsur-x86_64 arm64-release/269963.zip'
...
...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 505 HTTP Version not supported

https://build.webkit.org/builders/Apple-BigSur-Release-WK2-Tests/builds/44
Comment 1 Radar WebKit Bug Importer 2020-11-18 10:25:26 PST 
<rdar://problem/71545314>
Comment 2 Matt Lewis 2020-11-18 12:30:26 PST 
Looks like this is due to the space in the URL. Not sure how we archived the build product with a space, but we can fix it with a '+' in place of the space.
Comment 3 Matt Lewis 2020-11-18 12:32:52 PST 
Created attachment 414468 [details]
Patch
Comment 4 Matt Lewis 2020-11-18 12:35:30 PST 
Created attachment 414469 [details]
Patch
Comment 5 Matt Lewis 2020-11-18 12:36:04 PST 
re-uploaded for copyright fix
Comment 6 Matt Lewis 2020-11-18 13:04:05 PST 
Created attachment 414474 [details]
Patch
Comment 7 Matt Lewis 2020-11-18 13:04:56 PST 
At the request offline. Added python3 support. Also both quote and quote_plus work.
Comment 8 Aakash Jain 2020-11-18 13:10:24 PST 
Comment on attachment 414474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414474&action=review

> Tools/CISupport/download-built-product:32
> +try:

Instead of try except, it might be a good idea to use sys.version_info like: https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/system/path.py#L39
Comment 9 Matt Lewis 2020-11-18 13:15:01 PST 
Created attachment 414475 [details]
Patch
Comment 10 Aakash Jain 2020-11-18 13:19:06 PST 
Comment on attachment 414475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414475&action=review

> Tools/CISupport/download-built-product:3
> +# Copyright (C) 2009,2020 Apple Inc.  All rights reserved.

Nit: missing space after comma.
Comment 11 Matt Lewis 2020-11-18 13:43:08 PST 
Created attachment 414480 [details]
Patch for landing
Comment 12 EWS 2020-11-18 14:42:03 PST 
Committed r269988: <https://trac.webkit.org/changeset/269988>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414480 [details].