Bug 219080

Summary: Support <source> as a child of <model> to specify the current source
Product: WebKit Reporter: Antoine Quint <graouts>
Component: WebGLAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Antoine Quint
Reported 2020-11-18 05:13:48 PST
Support <source> as a child of <model> to specify the current source
Attachments
Patch (11.14 KB, patch)
2020-11-18 05:19 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2020-11-18 05:19:57 PST
Created attachment 414441 [details] Patch
Dean Jackson
Comment 2 2020-11-18 09:13:57 PST
Comment on attachment 414441 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414441&action=review > Source/WebCore/html/HTMLModelElement.cpp:79 > +void HTMLModelElement::didMoveToNewDocument(Document& oldDocument, Document& newDocument) Why would this change the source children? I guess their relative URLs may have changed?
Antoine Quint
Comment 3 2020-11-18 09:27:35 PST
(In reply to Dean Jackson from comment #2) > Comment on attachment 414441 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414441&action=review > > > Source/WebCore/html/HTMLModelElement.cpp:79 > > +void HTMLModelElement::didMoveToNewDocument(Document& oldDocument, Document& newDocument) > > Why would this change the source children? I guess their relative URLs may > have changed? Yes. I think this could also alter the availability of a browsing context?
EWS
Comment 4 2020-11-18 09:45:43 PST
Committed r269962: <https://trac.webkit.org/changeset/269962> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414441 [details].
Radar WebKit Bug Importer
Comment 5 2020-11-18 09:46:19 PST
<rdar://problem/71543368>
Note You need to log in before you can comment on or make changes to this bug.