Bug 219078

Summary: [GStreamer] GStreamerRegistryScanner cleanups and improvements
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, ews-watchlist, gustavo, lmoura, menard, pnormand, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch pnormand: review+

Carlos Garcia Campos
Reported 2020-11-18 04:42:56 PST
We are creating the factories and keeping them alive forever, because GStreamerRegistryScanner is singleton. We can just delete them after the initialization and then create the factories we need on demand when checking AV! codecs.
Attachments
Patch (44.58 KB, patch)
2020-11-18 04:53 PST, Carlos Garcia Campos 		pnormand: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-11-18 04:53:44 PST
Created attachment 414438 [details] Patch
Carlos Garcia Campos
Comment 2 2020-11-19 00:54:54 PST
Committed r270019: <https://trac.webkit.org/changeset/270019>
Radar WebKit Bug Importer
Comment 3 2020-11-19 00:55:16 PST
<rdar://problem/71577999>
Lauro Moura
Comment 4 2020-11-19 11:44:37 PST
The usage of OptionSet with All (`(1 << 8) - 1`) was asserting in debug: https://build.webkit.org/results/WPE-Linux-64-bit-Debug-Tests/r270023%20(5273)/css1/basic/contextual_selectors-crash-log.txt https://build.webkit.org/results/WPE-Linux-64-bit-Debug-Tests/r270023%20(5273)/results.html Tentative fix pushed in r270039 using fromRaw as suggested by Philippe.
Note You need to log in before you can comment on or make changes to this bug.