Bug 219061

Summary: [WebGL2] Rasterizer discard interferes with implicit clears
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, jdarpinian, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kenneth Russell
Reported 2020-11-17 18:22:42 PST
In Chromium bug http:///crbug.com/1149176 it was pointed out that enabling the RASTERIZER_DISCARD state interferes with the WebGL context's implicit auto-clears. A conformance test for this was just added in https://github.com/KhronosGroup/WebGL/pull/3183 ; WebKit needs fixes in this area as well.
Attachments
Patch (22.00 KB, patch)
2020-11-17 21:40 PST, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (12.93 KB, patch)
2020-11-20 13:57 PST, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (12.99 KB, patch)
2020-11-23 15:50 PST, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2020-11-17 21:40:44 PST
Created attachment 414410 [details] Patch
Kenneth Russell
Comment 2 2020-11-17 21:42:07 PST
Could I ask for a little help with the above patch? The new test fails in TestRunner, though it passes in MiniBrowser. I gather there are compositing differences in the test runner, but couldn't figure out if there are any Internals methods that can force a composite, for example.
Kenneth Russell
Comment 3 2020-11-20 13:57:51 PST
Created attachment 414717 [details] Patch
Kenneth Russell
Comment 4 2020-11-20 13:58:59 PST
Removed the new WebGL conformance test as a layout test after discussion with dino and kkinnunen - TestRunner doesn't pass it, but the browser and MiniBrowser do. Will do follow-on work on that.
Dean Jackson
Comment 5 2020-11-23 13:33:12 PST
Comment on attachment 414717 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414717&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:467 > + : m_context(context), m_wasEnabled(wasEnabled) Nit: we do this on two lines. > Source/WebCore/html/canvas/WebGLRenderingContextBase.h:650 > + bool m_rasterizerDiscardEnabled; Not necessary now, but we should probably go through these and give them default values.
Kenneth Russell
Comment 6 2020-11-23 15:49:13 PST
Comment on attachment 414717 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414717&action=review >> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:467 >> + : m_context(context), m_wasEnabled(wasEnabled) > > Nit: we do this on two lines. Done. >> Source/WebCore/html/canvas/WebGLRenderingContextBase.h:650 >> + bool m_rasterizerDiscardEnabled; > > Not necessary now, but we should probably go through these and give them default values. Yes, let's do that - strongly prefer that style. Fixed this new one.
Kenneth Russell
Comment 7 2020-11-23 15:50:07 PST
Created attachment 414815 [details] Patch
Kenneth Russell
Comment 8 2020-11-23 21:24:59 PST
Comment on attachment 414815 [details] Patch Forgot that the repo's closed this week.
Radar WebKit Bug Importer
Comment 9 2020-11-26 03:19:06 PST
<rdar://problem/71747708>
Kenneth Russell
Comment 10 2020-11-30 11:06:42 PST
Comment on attachment 414815 [details] Patch Attempting cq+.
EWS
Comment 11 2020-11-30 11:21:15 PST
Committed r270253: <https://trac.webkit.org/changeset/270253> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414815 [details].
Kenneth Russell
Comment 12 2020-11-30 13:55:55 PST
For what it's worth, I analyzed the layout test failures seen by the EWS as being unrelated to this patch. Please tell me if that seems to not be the case.
Note You need to log in before you can comment on or make changes to this bug.