Bug 219043

Summary: [CMake] generate_offset_extractor.rb missing build dependency for llint/WebAssembly.asm
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: JavaScriptCoreAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, don.olmstead, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, mcatanzaro, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2020-11-17 11:32:17 PST
Trying to guess why EWS is failing in bug #210302, I noticed that generate_offset_extractor.rb is missing a build dependency for llint/WebAssembly.asm. Sadly, this doesn't explain the build failure in that bug, because that patch modifies several other files that should cause this script to run. But let's fix it anyway.
Attachments
Patch (1.30 KB, patch)
2020-11-17 15:34 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2020-11-17 11:38:17 PST
My working dir is pretty dirty right now. The fix I will upload when ready is: diff --git a/Source/JavaScriptCore/CMakeLists.txt b/Source/JavaScriptCore/CMakeLists.txt index 38ae6ce11a89..82311f380df2 100644 --- a/Source/JavaScriptCore/CMakeLists.txt +++ b/Source/JavaScriptCore/CMakeLists.txt @@ -192,6 +192,7 @@ set(LLINT_ASM llint/LowLevelInterpreter.asm llint/LowLevelInterpreter32_64.asm llint/LowLevelInterpreter64.asm + llint/WebAssembly.asm ) set(OFFLINE_ASM
Michael Catanzaro
Comment 2 2020-11-17 15:34:45 PST
Created attachment 414392 [details] Patch
EWS
Comment 3 2020-11-17 16:04:39 PST
Committed r269933: <https://trac.webkit.org/changeset/269933> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414392 [details].
Radar WebKit Bug Importer
Comment 4 2020-11-17 16:07:53 PST
<rdar://problem/71510500>
Note You need to log in before you can comment on or make changes to this bug.