Bug 219026

Summary: Build fails on internal Catalina due to missing enum kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dino, eric.carlson, ews-watchlist, glenn, graouts, jer.noble, koivisto, kondapallykalyan, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 218637    
Bug Blocks: 219030    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kimmo Kinnunen
Reported 2020-11-17 01:38:41 PST
Build fails on internal Catalina due to missing enum kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange
Attachments
Patch (2.05 KB, patch)
2020-11-17 01:51 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (4.20 KB, patch)
2020-11-17 02:33 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (4.29 KB, patch)
2020-11-17 02:47 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2020-11-17 01:51:42 PST
Created attachment 414320 [details] Patch
Antti Koivisto
Comment 2 2020-11-17 02:12:59 PST
Comment on attachment 414320 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414320&action=review > Source/WebCore/PAL/pal/spi/cf/CoreVideoSPI.h:30 > +#if USE(APPLE_INTERNAL_SDK) && HAVE(CV_AGX_420_PIXEL_FORMAT_TYPES) Might be better to ifdef the call site?
Kimmo Kinnunen
Comment 3 2020-11-17 02:33:51 PST
Created attachment 414325 [details] Patch
Antti Koivisto
Comment 4 2020-11-17 02:34:40 PST
Comment on attachment 414325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414325&action=review > Source/WebCore/PAL/pal/spi/cf/CoreVideoSPI.h:30 > +#if USE(APPLE_INTERNAL_SDK) && HAVE(CV_AGX_420_PIXEL_FORMAT_TYPES) This shouldn't be needed now.
Kimmo Kinnunen
Comment 5 2020-11-17 02:47:39 PST
Created attachment 414327 [details] Patch
EWS
Comment 6 2020-11-17 06:07:22 PST
Committed r269898: <https://trac.webkit.org/changeset/269898> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414327 [details].
Radar WebKit Bug Importer
Comment 7 2020-11-17 06:08:21 PST
<rdar://problem/71484045>
Note You need to log in before you can comment on or make changes to this bug.