| Summary: | Build fails on internal Catalina due to missing enum kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||||||
| Component: | WebGL | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, dino, eric.carlson, ews-watchlist, glenn, graouts, jer.noble, koivisto, kondapallykalyan, philipj, sergio, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 218637 | ||||||||||
| Bug Blocks: | 219030 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Kimmo Kinnunen
2020-11-17 01:38:41 PST
Created attachment 414320 [details]
Patch
Comment on attachment 414320 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414320&action=review > Source/WebCore/PAL/pal/spi/cf/CoreVideoSPI.h:30 > +#if USE(APPLE_INTERNAL_SDK) && HAVE(CV_AGX_420_PIXEL_FORMAT_TYPES) Might be better to ifdef the call site? Created attachment 414325 [details]
Patch
Comment on attachment 414325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414325&action=review > Source/WebCore/PAL/pal/spi/cf/CoreVideoSPI.h:30 > +#if USE(APPLE_INTERNAL_SDK) && HAVE(CV_AGX_420_PIXEL_FORMAT_TYPES) This shouldn't be needed now. Created attachment 414327 [details]
Patch
Committed r269898: <https://trac.webkit.org/changeset/269898> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414327 [details]. |