Bug 219021

Summary:

Add a default action for SpeechRecognition permission request

Product:

WebKit

Reporter:

Sihui Liu <sihui_liu>

Component:

WebCore Misc.

Assignee:

Sihui Liu <sihui_liu>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=219891

Attachments:

Description	Flags
Patch	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none

Sihui Liu

Reported 2020-11-16 21:35:41 PST

...

Attachments
Patch (22.92 KB, patch) 2020-11-16 21:48 PST, Sihui Liu	no flags	Details Formatted Diff Diff
Patch (26.16 KB, patch) 2020-11-17 10:34 PST, Sihui Liu	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (27.43 KB, patch) 2020-11-17 11:02 PST, Sihui Liu	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (27.45 KB, patch) 2020-11-17 11:26 PST, Sihui Liu	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Sihui Liu

Comment 1 2020-11-16 21:48:40 PST

Created attachment 414306 [details] Patch

youenn fablet

Comment 2 2020-11-17 09:34:02 PST

Comment on attachment 414306 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414306&action=review > Source/WebKit/UIProcess/Cocoa/UserMediaPermissionRequestProxy.mm:29 > #if ENABLE(MEDIA_STREAM) UserMediaPermissionRequestProxy.mm can probably be removed if we move the alter code in MediaPermissionUtilities.mm. > Source/WebKit/UIProcess/MediaPermissionUtilities.h:77 > +template<> struct EnumTraits<WebKit::MediaPermissionType> { Do we need to send this over IPC? > Source/WebKit/UIProcess/WebPageProxy.cpp:10251 > +void WebPageProxy::decidePolicyForSpeechRecognitionPermission(const WebCore::SecurityOrigin& origin, CompletionHandler<void(bool)>&& completionHandler) Maybe the name could be more descriptive here. I don't have a good name though.

Sihui Liu

Comment 3 2020-11-17 09:58:43 PST

(In reply to youenn fablet from comment #2) > Comment on attachment 414306 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414306&action=review > > > Source/WebKit/UIProcess/Cocoa/UserMediaPermissionRequestProxy.mm:29 > > #if ENABLE(MEDIA_STREAM) > > UserMediaPermissionRequestProxy.mm can probably be removed if we move the > alter code in MediaPermissionUtilities.mm. Yes, will try removing it. > > > Source/WebKit/UIProcess/MediaPermissionUtilities.h:77 > > +template<> struct EnumTraits<WebKit::MediaPermissionType> { > > Do we need to send this over IPC? Nope, will remove. > > > Source/WebKit/UIProcess/WebPageProxy.cpp:10251 > > +void WebPageProxy::decidePolicyForSpeechRecognitionPermission(const WebCore::SecurityOrigin& origin, CompletionHandler<void(bool)>&& completionHandler) > > Maybe the name could be more descriptive here. I don't have a good name > though. hmm, will change to requestSpeechRecognitionPermissionByDefaultAction.

Sihui Liu

Comment 4 2020-11-17 10:34:47 PST

Created attachment 414352 [details] Patch

Sihui Liu

Comment 5 2020-11-17 11:02:11 PST

Created attachment 414354 [details] Patch

Sihui Liu

Comment 6 2020-11-17 11:26:55 PST

Created attachment 414356 [details] Patch

EWS

Comment 7 2020-11-17 13:01:09 PST

Committed r269918: <https://trac.webkit.org/changeset/269918> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414356 [details].

Radar WebKit Bug Importer

Comment 8 2020-11-17 13:02:18 PST

<rdar://problem/71499713>

Note You need to log in before you can comment on or make changes to this bug.