Bug 219002

Summary: [GPUProcess] Update GPUProcess process assertion based on active WebProcesses
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ggaren, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2020-11-16 13:17:26 PST
Update GPUProcess process assertion based on active WebProcesses, similarly to what we do for the network process.
Attachments
Patch (2.70 KB, patch)
2020-11-16 13:19 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-11-16 13:19:36 PST
Created attachment 414274 [details] Patch
EWS
Comment 2 2020-11-16 14:17:46 PST
Committed r269879: <https://trac.webkit.org/changeset/269879> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414274 [details].
Radar WebKit Bug Importer
Comment 3 2020-11-16 14:18:18 PST
<rdar://problem/71459123>
Darin Adler
Comment 4 2020-11-16 16:15:39 PST
Comment on attachment 414274 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414274&action=review > Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:288 > + // Use std::exchange() instead of a simple nullptr assignment to avoid re-entering this > + // function during the destructor of the ProcessThrottler activity, before setting > + // m_activityFromWebProcesses. > + std::exchange(m_activityFromWebProcesses, nullptr); Could this be fixed by changing the Variant implementation instead? I remember something similar for our smart pointers and we fixed that in the smart pointer class rather than at call sites.
Note You need to log in before you can comment on or make changes to this bug.