Bug 218997

Summary:

NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking() redacts the cookie name in log output on customer builds

Product:

WebKit

Reporter:

John Wilander <wilander>

Component:

WebKit Misc.

Assignee:

John Wilander <wilander>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch for landing	none

John Wilander

Reported 2020-11-16 12:18:33 PST

NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking() redacts the cookie name in log output on customer builds. We should change the format specifier from %s to %{public}s. Note that this logging is just for ITP Debug Mode which is off by default, logs in-memory only, and is disabled again on browser quit.

Attachments
Patch for landing (2.29 KB, patch) 2020-11-16 15:01 PST, John Wilander	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-11-16 14:53:45 PST

<rdar://problem/71460604>

John Wilander

Comment 2 2020-11-16 15:01:28 PST

Created attachment 414281 [details] Patch for landing

EWS

Comment 3 2020-11-16 15:52:11 PST

Committed r269885: <https://trac.webkit.org/changeset/269885> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414281 [details].

Note You need to log in before you can comment on or make changes to this bug.