Bug 218991

Summary: Add an experimental <model> element
Product: WebKit Reporter: Antoine Quint <graouts>
Component: WebGLAssignee: Antoine Quint <graouts>
Severity: Normal CC: annulen, benjamin, calvaris, cdumez, changseok, cmarcelo, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
ews-feeder: commit-queue-
Patch none

Description Antoine Quint 2020-11-16 10:14:03 PST
Add an experimental <model> element
Comment 1 Antoine Quint 2020-11-16 10:18:49 PST
Created attachment 414249 [details]
Comment 2 Antoine Quint 2020-11-16 10:54:45 PST
Created attachment 414256 [details]
Comment 3 EWS 2020-11-16 14:40:49 PST
Committed r269880: <https://trac.webkit.org/changeset/269880>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414256 [details].
Comment 4 Radar WebKit Bug Importer 2020-11-16 14:41:18 PST
Comment 5 Simon Fraser (smfr) 2020-11-16 15:02:21 PST
Comment on attachment 414256 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=414256&action=review

> LayoutTests/ChangeLog:8
> +        Add a new system-preview/model subdirectory for <model> tests, which we run on macOS and iOS.

Why "system-preview"? You're adding an HTML element, which doesn't sound like a system-preview.
Comment 6 Antoine Quint 2020-11-17 03:35:08 PST
This shouldn't have been made enabled if ENABLE(EXPERIMENTAL_FEATURES) since this enables in STP as well. We really want this to be opt-in completely, even if that requires opting into the feature in tests as well. I'll correct this in bug 219027.