Summary: | Add an experimental <model> element | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||
Component: | WebGL | Assignee: | Antoine Quint <graouts> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | annulen, benjamin, calvaris, cdumez, changseok, cmarcelo, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Antoine Quint
2020-11-16 10:14:03 PST
Created attachment 414249 [details]
Patch
Created attachment 414256 [details]
Patch
Committed r269880: <https://trac.webkit.org/changeset/269880> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414256 [details]. Comment on attachment 414256 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414256&action=review > LayoutTests/ChangeLog:8 > + Add a new system-preview/model subdirectory for <model> tests, which we run on macOS and iOS. Why "system-preview"? You're adding an HTML element, which doesn't sound like a system-preview. This shouldn't have been made enabled if ENABLE(EXPERIMENTAL_FEATURES) since this enables in STP as well. We really want this to be opt-in completely, even if that requires opting into the feature in tests as well. I'll correct this in bug 219027. |