| Summary: | [css-flex] Images as flex items should use the overridingLogicalHeight when defined to compute the logical width | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||||||
| Component: | New Bugs | Assignee: | Sergio Villar Senin <svillar> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | changseok, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, rbuis, rego, rniwa, simon.fraser, svillar, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Sergio Villar Senin
2020-11-16 02:56:21 PST
Created attachment 414213 [details]
Patch
Created attachment 414322 [details]
Patch
Comment on attachment 414322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414322&action=review > Source/WebCore/rendering/RenderReplaced.cpp:527 > + ASSERT(intrinsicRatio); intrisicRatio can be zero, so this ASSERT will crash (like it's happening on the debug EWS), Shouldn't we add it in the previous check? (In reply to Manuel Rego Casasnovas from comment #3) > Comment on attachment 414322 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414322&action=review > > > Source/WebCore/rendering/RenderReplaced.cpp:527 > > + ASSERT(intrinsicRatio); > > intrisicRatio can be zero, so this ASSERT will crash (like it's happening on > the debug EWS), Shouldn't we add it in the previous check? I'm trying to know how intrinsicRatio is zero given that both the intrinsic width and the intrinsic height are > 0. I thought it won't be possible, that's why I added the ASSERT. (In reply to Sergio Villar Senin from comment #4) > (In reply to Manuel Rego Casasnovas from comment #3) > > Comment on attachment 414322 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=414322&action=review > > > > > Source/WebCore/rendering/RenderReplaced.cpp:527 > > > + ASSERT(intrinsicRatio); > > > > intrisicRatio can be zero, so this ASSERT will crash (like it's happening on > > the debug EWS), Shouldn't we add it in the previous check? > > I'm trying to know how intrinsicRatio is zero given that both the intrinsic > width and the intrinsic height are > 0. I thought it won't be possible, > that's why I added the ASSERT. Right so for example an iframe has indeed a intrinsic size but not necessarily an aspect ratio. Will change the condition and remove the assert Created attachment 414442 [details]
Patch
Comment on attachment 414442 [details]
Patch
r=me
Committed r270073: <https://trac.webkit.org/changeset/270073> |