Summary: | PCM: Change attribute and JSON key names according to the W3C conversation | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Wilander <wilander> | ||||||||||
Component: | WebCore Misc. | Assignee: | John Wilander <wilander> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bfulgham, cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, japhet, kondapallykalyan, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
John Wilander
2020-11-15 18:03:08 PST
Created attachment 414186 [details]
Patch
Created attachment 414260 [details]
Patch
Created attachment 414268 [details]
Patch
win build failure looks unrelated. ios-wk2 test failure is unrelated. Comment on attachment 414268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414268&action=review Looks good. Nice to have the spec coming together! r=me. > Source/WebCore/ChangeLog:8 > + Weâve discussed extensively with Google and others on naming for the link Looks like you got a smart-quote in here. > Source/WebCore/html/HTMLAnchorElement.cpp:426 > + document().addConsoleMessage(MessageSource::Other, MessageLevel::Warning, "Both attributionsourceid and attributeon need to be set for Private Click Measurement to work."_s); I know that this is correct, but at first I thought "attributeon" was misspelled. > Source/WebCore/html/HTMLAttributeNames.in:70 > +attributeon I wish this had been spec'd as "attribute-on" (In reply to Brent Fulgham from comment #7) > Comment on attachment 414268 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414268&action=review > > Looks good. Nice to have the spec coming together! r=me. > > > Source/WebCore/ChangeLog:8 > > + Weâve discussed extensively with Google and others on naming for the link > > Looks like you got a smart-quote in here. Good catch. Will fix. > > Source/WebCore/html/HTMLAnchorElement.cpp:426 > > + document().addConsoleMessage(MessageSource::Other, MessageLevel::Warning, "Both attributionsourceid and attributeon need to be set for Private Click Measurement to work."_s); > > I know that this is correct, but at first I thought "attributeon" was > misspelled. > > > Source/WebCore/html/HTMLAttributeNames.in:70 > > +attributeon > > I wish this had been spec'd as "attribute-on" I agree but Google referred to this TAG document (see "HTML elements and attributes"): https://w3ctag.github.io/design-principles/#casing-rules Thanks for the review! Created attachment 414282 [details]
Patch for landing
Committed r269886: <https://trac.webkit.org/changeset/269886> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414282 [details]. |