Bug 218966

Summary:

Remove and re-add fast/forms/selection-direction.html without CRs

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=217567

Attachments:

Description	Flags
Remove test temporarily	none

Sam Weinig

Reported 2020-11-15 16:00:22 PST

fast/forms/selection-direction.html has CR line ending and the scripts won't allow me to change it. They will allow me to remove it though, so let's remove it and add it back without the line endings.

Attachments
Remove test temporarily (4.64 KB, patch) 2020-11-15 16:01 PST, Sam Weinig	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2020-11-15 16:01:55 PST

Created attachment 414184 [details] Remove test temporarily

EWS

Comment 2 2020-11-15 16:33:50 PST

Committed r269834: <https://trac.webkit.org/changeset/269834> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414184 [details].

Radar WebKit Bug Importer

Comment 3 2020-11-15 16:34:19 PST

<rdar://problem/71421831>

Darin Adler

Comment 4 2020-11-15 16:39:26 PST

Seems like we didn’t need to use a bug and commit-queue for this. Could just use git/svn directly.

Sam Weinig

Comment 5 2020-11-16 08:54:02 PST

(In reply to Darin Adler from comment #4) > Seems like we didn’t need to use a bug and commit-queue for this. Could just > use git/svn directly. Yeah, I didn't think it through. Should have done that.

Sam Weinig

Comment 6 2020-11-16 09:05:08 PST

Added test back in https://trac.webkit.org/changeset/269854/webkit.

Note You need to log in before you can comment on or make changes to this bug.