Bug 218958

Summary: Add logging of AXCoreObject outerHTML to AXLogger.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Andres Gonzalez 2020-11-15 09:36:55 PST 
Add logging of AXCoreObject outerHTML to AXLogger.
Comment 1 Andres Gonzalez 2020-11-15 09:43:47 PST 
Created attachment 414167 [details]
Patch
Comment 2 chris fleizach 2020-11-16 00:11:36 PST 
Comment on attachment 414167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414167&action=review

> Source/WebCore/accessibility/AXLogger.cpp:270
> +    const AXCoreObject* objectWithInterestingHtML = nullptr;

HtML > HTML

can we use auto here?
Comment 3 Andres Gonzalez 2020-11-16 06:40:35 PST 
Created attachment 414230 [details]
Patch
Comment 4 Andres Gonzalez 2020-11-16 06:42:19 PST 
(In reply to chris fleizach from comment #2)
> Comment on attachment 414167 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414167&action=review
> 
> > Source/WebCore/accessibility/AXLogger.cpp:270
> > +    const AXCoreObject* objectWithInterestingHtML = nullptr;
> 
> HtML > HTML

Fixed.
> 
> can we use auto here?

Done.
Comment 5 EWS 2020-11-16 10:12:38 PST 
Committed r269859: <https://trac.webkit.org/changeset/269859>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414230 [details].
Comment 6 Radar WebKit Bug Importer 2020-11-16 10:13:17 PST 
<rdar://problem/71446493>