Bug 218956

Summary: TextEncoderStreamEncoder should not be exposed
Product: WebKit Reporter: youenn fablet <youennf>
Component: DOMAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, esprehn+autocc, ews-watchlist, kondapallykalyan, sam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2020-11-15 04:12:37 PST
As spotted by Yusuke, TextEncoderStreamEncoder should not be exposed, ditto for TextDecoderStreamDecoder
Attachments
Patch (20.39 KB, patch)
2020-11-15 04:31 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (20.28 KB, patch)
2020-11-15 09:54 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.58 KB, patch)
2020-11-16 00:01 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-11-15 04:31:11 PST
Created attachment 414162 [details] Patch
youenn fablet
Comment 2 2020-11-15 09:54:16 PST
Created attachment 414168 [details] Patch
Yusuke Suzuki
Comment 3 2020-11-15 10:48:57 PST
Comment on attachment 414168 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414168&action=review r=me > Source/WebCore/bindings/scripts/test/JS/JSDOMWindow.cpp:206 > + if ((jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecutionContext()->isSecureContext() && TestEnabledForContext::enabledForContext(*jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecutionContext()))) { Looks like we need to remove this brace. > Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:248 > + if (downcast<Document>(jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecutionContext())->settings().testSettingEnabled()) { Ditto about the brace. > Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:251 > + if (downcast<Document>(jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecutionContext())->settings().testSettingEnabled()) { Ditto. > Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp:717 > + if (RuntimeEnabledFeatures::sharedFeatures().testFeatureEnabled()) { Ditto.
youenn fablet
Comment 4 2020-11-16 00:01:45 PST
Created attachment 414197 [details] Patch for landing
EWS
Comment 5 2020-11-16 04:18:12 PST
Committed r269847: <https://trac.webkit.org/changeset/269847> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414197 [details].
Radar WebKit Bug Importer
Comment 6 2020-11-16 04:19:16 PST
<rdar://problem/71434621>
Note You need to log in before you can comment on or make changes to this bug.