Bug 218935

Summary:

[webkitscmpy] Generalize parts of local.Scm class

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=218827

Attachments:

Description	Flags
Patch	none
Patch	none

Description Jonathan Bedard 2020-11-13 21:01:33 PST

Some of the logic in the local.Scm class is also applicable for remote repositories. We should break those parts off into a more generic base class that local.Scm inherits from.

Comment 1 Radar WebKit Bug Importer 2020-11-13 21:02:24 PST

<rdar://problem/71395688>

Comment 2 Jonathan Bedard 2020-11-13 21:05:31 PST

Created attachment 414123 [details]
Patch

Comment 3 Aakash Jain 2020-11-16 15:47:59 PST

Comment on attachment 414123 [details]
Patch

rs=me

Comment 4 Jonathan Bedard 2020-11-16 17:10:03 PST

Created attachment 414295 [details]
Patch

Comment 5 EWS 2020-11-16 19:17:40 PST

Committed r269891: <https://trac.webkit.org/changeset/269891>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414295 [details].