Bug 218935

Summary: [webkitscmpy] Generalize parts of local.Scm class
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=218827
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2020-11-13 21:01:33 PST
Some of the logic in the local.Scm class is also applicable for remote repositories. We should break those parts off into a more generic base class that local.Scm inherits from.
Attachments
Patch (13.77 KB, patch)
2020-11-13 21:05 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (13.80 KB, patch)
2020-11-16 17:10 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-11-13 21:02:24 PST
<rdar://problem/71395688>
Jonathan Bedard
Comment 2 2020-11-13 21:05:31 PST
Created attachment 414123 [details] Patch
Aakash Jain
Comment 3 2020-11-16 15:47:59 PST
Comment on attachment 414123 [details] Patch rs=me
Jonathan Bedard
Comment 4 2020-11-16 17:10:03 PST
Created attachment 414295 [details] Patch
EWS
Comment 5 2020-11-16 19:17:40 PST
Committed r269891: <https://trac.webkit.org/changeset/269891> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414295 [details].
Note You need to log in before you can comment on or make changes to this bug.