Bug 218916

Summary: [clang-tidy] Run modernize-use-override through JSC
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Don Olmstead
Reported 2020-11-13 11:10:08 PST
The modernizer fix isn't smart enough to use final for final classes so fix those up.
Attachments
Patch (12.13 KB, patch)
2020-11-13 11:16 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (12.12 KB, patch)
2020-11-13 12:39 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2020-11-13 11:16:18 PST
Created attachment 414067 [details] Patch
Don Olmstead
Comment 2 2020-11-13 12:39:12 PST
Created attachment 414083 [details] Patch
Yusuke Suzuki
Comment 3 2020-11-14 02:00:29 PST
Comment on attachment 414083 [details] Patch r=me
EWS
Comment 4 2020-11-14 02:29:17 PST
Committed r269814: <https://trac.webkit.org/changeset/269814> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414083 [details].
Radar WebKit Bug Importer
Comment 5 2020-11-14 02:31:33 PST
<rdar://problem/71398957>
Note You need to log in before you can comment on or make changes to this bug.