Description
Andy Estes
2020-11-13 09:04:03 PST
Created attachment 414179 [details]
WIP
Work in(In reply to Andy Estes from comment #3) > Created attachment 414179 [details] > WIP Still plenty of cleanup left to do, notably: 1. The plug-in should move from WebCore to WebKit since it must link the WebKit umbrella framework on Mac. 2. The WebContent process needs to register the plug-in at runtime (although this is testable now in a stand-alone test executable). 3. Needs a runtime flag. Created attachment 414376 [details]
WIP
Created attachment 414381 [details]
WIP
Created attachment 414391 [details]
More WIP: add a runtime flag
Created attachment 415157 [details]
More WIP: SampleCursor improvements
Created attachment 415688 [details]
Another WIP
Created attachment 415695 [details]
Another WIP
Created attachment 415725 [details]
Another WIP
Created attachment 415734 [details]
More WIP: Implement SampleCursor::copySampleLocation
Created attachment 415814 [details]
More WIP: cleanup and refactor SourceBufferParserWebM
Created attachment 415815 [details]
Part 1: Install a format reader plug-in in WebKit.framework/PlugIns
Created attachment 415949 [details]
Part 1: Create a format reader plug-in for WebM
Created attachment 415952 [details]
Part 2: Register the format reader plug-in for WebM content types
Created attachment 415953 [details]
Part 2: Register the format reader plug-in for WebM content types
Created attachment 415956 [details]
Part 2: Register the format reader plug-in for WebM content types
Created attachment 415957 [details]
Part 2: Register the format reader plug-in for WebM content types
Created attachment 415961 [details]
Part 2: Register the format reader plug-in for WebM content types
Committed r270666: <https://trac.webkit.org/changeset/270666> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415949 [details]. Reopening to attach new patch. Created attachment 415972 [details]
Part 3: Abstract SourceBufferParser segments
Patch 415961 does not build Created attachment 416054 [details]
Part 2: Register the format reader plug-in for WebM content types
Created attachment 416056 [details]
Part 3: Abstract SourceBufferParser segments
/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Created attachment 416057 [details]
Part 3: Abstract SourceBufferParser segments
Committed r270717: <https://trac.webkit.org/changeset/270717> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416057 [details]. Reopening to attach new patch. Found 4 new test failures: imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType.html, imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html, imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/resize-during-playback.html, media/media-can-play-webm.html Created attachment 416085 [details]
Part 4: Implement and test the format reader
Created attachment 416094 [details]
Part 4: Implement and test the format reader
Created attachment 416095 [details]
Part 4: Implement and test the format reader
Created attachment 416098 [details]
Part 4: Implement and test the format reader
Created attachment 416102 [details]
Part 4: Implement and test the format reader
Created attachment 416103 [details]
Part 4: Implement and test the format reader
Created attachment 416104 [details]
Part 4: Implement and test the format reader
Created attachment 416106 [details]
Part 4: Implement and test the format reader
Created attachment 416113 [details]
Patch for landing
Created attachment 416123 [details]
Patch for landing
Created attachment 416125 [details]
Patch for landing
Created attachment 416128 [details]
Patch for landing
Created attachment 416130 [details]
Patch for landing
Created attachment 416131 [details]
Patch for landing
Committed r270758: <https://trac.webkit.org/changeset/270758> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416131 [details]. Fixed the build in r270760: <https://trac.webkit.org/changeset/270760> Fixed the build in r270761: <https://trac.webkit.org/changeset/270761> This caused an Internal testing failure tracked in: rdar://72600426 |