Bug 218902

Summary: Add support for discrete animations of many CSS properties
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, dino, esprehn+autocc, ews-watchlist, glenn, jfernandez, jordan, koivisto, kondapallykalyan, pdr, rego, svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=221589
Attachments:
Description Flags
Patch
koivisto: review+, ews-feeder: commit-queue-
Patch none

Antoine Quint
Reported 2020-11-13 07:19:24 PST
Add support for discrete animations of many CSS properties
Attachments
Patch (110.23 KB, patch)
2020-11-13 08:10 PST, Antoine Quint 		koivisto: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (121.99 KB, patch)
2020-11-13 12:19 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2020-11-13 07:34:06 PST
Namely: -webkit-backface-visibility, -webkit-box-decoration-break, -webkit-hyphens, -webkit-initial-letter, -webkit-print-color-adjust, -webkit-ruby-position, -webkit-text-emphasis-color, -webkit-text-emphasis-position, border-bottom-style, border-collapse, border-left-style, border-right-style, border-top-style, box-sizing, caption-side, clear, column-fill, column-rule-style, column-rule-style, cursor, empty-cells, flex-direction, flex-wrap, float, grid-auto-columns, grid-auto-flow, grid-auto-rows, grid-column-end, grid-column-start, grid-row-end, grid-row-start, image-orientation, isolation, justify-content, justify-items, justify-self, list-style-position, list-style-type, mix-blend-mode, object-fit, outline-style, overflow-wrap, overflow-x, overflow-y, page-break-after, page-break-before, page-break-inside, paint-order, pointer-events, position, resize, scroll-behavior, table-layout, text-align, text-decoration-color, text-decoration-line, text-decoration-style, text-overflow, text-transform, touch-action, transform-box, transform-style, white-space, word-break.
Antoine Quint
Comment 2 2020-11-13 08:10:14 PST
Created attachment 414044 [details] Patch
Antti Koivisto
Comment 3 2020-11-13 08:15:06 PST
Comment on attachment 414044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414044&action=review > Source/WebCore/animation/CSSPropertyAnimation.cpp:1917 > new DiscretePropertyWrapper<const StyleContentAlignmentData&>(CSSPropertyAlignContent, &RenderStyle::alignContent, &RenderStyle::setAlignContent), > new DiscretePropertyWrapper<const StyleSelfAlignmentData&>(CSSPropertyAlignItems, &RenderStyle::alignItems, &RenderStyle::setAlignItems), > new DiscretePropertyWrapper<const StyleSelfAlignmentData&>(CSSPropertyAlignSelf, &RenderStyle::alignSelf, &RenderStyle::setAlignSelf), > + new DiscretePropertyWrapper<BackfaceVisibility>(CSSPropertyWebkitBackfaceVisibility, &RenderStyle::backfaceVisibility, &RenderStyle::setBackfaceVisibility), Maybe this stuff should be generated from CSSProperties.json?
Antoine Quint
Comment 4 2020-11-13 12:18:48 PST
Actually, scroll-behavior will be for another bug.
Antoine Quint
Comment 5 2020-11-13 12:19:28 PST
Created attachment 414077 [details] Patch
Antoine Quint
Comment 6 2020-11-14 00:53:18 PST
Committed r269812: <https://trac.webkit.org/changeset/269812>
Radar WebKit Bug Importer
Comment 7 2020-11-14 00:54:18 PST
<rdar://problem/71398181>
Antoine Quint
Comment 8 2020-12-07 00:05:27 PST
*** Bug 219564 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.