Bug 218879

Summary: Add menu support for app highlights for books
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 232642    
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Megan Gardner
Reported 2020-11-12 17:25:06 PST
Add menu support for app highlights for books
Attachments
Patch (29.05 KB, patch)
2020-11-12 18:13 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (28.85 KB, patch)
2020-11-13 09:21 PST, Megan Gardner 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (28.82 KB, patch)
2020-11-13 09:49 PST, Megan Gardner 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (29.93 KB, patch)
2020-11-13 10:54 PST, Megan Gardner 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (28.78 KB, patch)
2020-11-13 11:19 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (26.24 KB, patch)
2020-11-13 17:09 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (26.24 KB, patch)
2020-11-13 17:14 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (26.19 KB, patch)
2020-11-16 09:50 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (26.20 KB, patch)
2020-11-16 10:16 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (26.22 KB, patch)
2020-11-16 10:57 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2020-11-12 18:13:49 PST
Created attachment 413988 [details] Patch
Alex Christensen
Comment 2 2020-11-13 07:43:55 PST
Comment on attachment 413988 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413988&action=review > Source/WebCore/WebCore.xcodeproj/project.pbxproj:35321 > + 446EE4E7255DF00D00454463 /* Concatenate Localizable.strings */ = { Did you mean to add this? It doesn't say what this is doing in the ChangeLog. > Source/WebCore/page/ContextMenuController.cpp:411 > + case ContextMenuItemTagAddHighlightToCurrentGroup: #if PLATFORM(COCOA) > Source/WebCore/page/ContextMenuController.cpp:931 > + if (Page* page = frame->page()) { auto*
Megan Gardner
Comment 3 2020-11-13 09:21:07 PST
Created attachment 414051 [details] Patch
Megan Gardner
Comment 4 2020-11-13 09:49:47 PST
Created attachment 414057 [details] Patch
Megan Gardner
Comment 5 2020-11-13 10:54:05 PST
Created attachment 414062 [details] Patch
Megan Gardner
Comment 6 2020-11-13 11:19:04 PST
Created attachment 414069 [details] Patch
Tim Horton
Comment 7 2020-11-13 15:35:09 PST
Comment on attachment 414069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414069&action=review > Source/WebKit/FeatureFlags/WebKit.plist:2 > <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> If you could avoid sorting and reindenting this, that would be grand for blaming/merging purposes. > Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:113 > +#if PLATFORM(IOS_FAMILY) || PLATFORM(MAC) This should be an ENABLE
Tim Horton
Comment 8 2020-11-13 15:36:24 PST
Comment on attachment 414069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414069&action=review > Source/WebCore/ChangeLog:9 > + Add menu items and associated plubling for support for books highlights in modern webkit. plubling WebKit
Megan Gardner
Comment 9 2020-11-13 17:09:34 PST
Created attachment 414110 [details] Patch
Megan Gardner
Comment 10 2020-11-13 17:14:46 PST
Created attachment 414111 [details] Patch
Alex Christensen
Comment 11 2020-11-14 16:02:58 PST
Comment on attachment 414111 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414111&action=review > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:60 > + WebKitLegacy: This and WebCore: are probably not necessary, since it's only exposed in WebKit. > Source/WebCore/page/ContextMenuController.cpp:465 > + // TODO: Add Highlight Logic I think WebKit style prefers FIXME over TODO.
Megan Gardner
Comment 12 2020-11-16 09:50:56 PST
Created attachment 414244 [details] Patch
Megan Gardner
Comment 13 2020-11-16 10:16:47 PST
Created attachment 414248 [details] Patch for landing
Megan Gardner
Comment 14 2020-11-16 10:57:03 PST
Created attachment 414257 [details] Patch for landing
EWS
Comment 15 2020-11-16 11:33:12 PST
Committed r269865: <https://trac.webkit.org/changeset/269865> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414257 [details].
Radar WebKit Bug Importer
Comment 16 2020-11-16 11:34:18 PST
<rdar://problem/71450870>
Megan Gardner
Comment 17 2020-11-16 11:47:31 PST
<rdar://problem/71352113>
Simon Fraser (smfr)
Comment 18 2020-11-16 12:02:49 PST
Comment on attachment 414257 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=414257&action=review > Source/WTF/ChangeLog:3 > + Add menu support for app highlights for books menu -> context menu, but too late now.
Note You need to log in before you can comment on or make changes to this bug.