Bug 218820

Summary: [iOS] IOKit sandbox violation when enabling all GPU runtime flags
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Per Arne Vollan 2020-11-11 13:14:56 PST
When enabling all GPU runtime flags on iOS, there is an iokit-open sandbox violation in the WebContent process.
Comment 1 Radar WebKit Bug Importer 2020-11-11 13:16:18 PST
<rdar://problem/71296116>
Comment 2 Per Arne Vollan 2020-11-11 13:38:01 PST
Created attachment 413859 [details]
Patch
Comment 3 Per Arne Vollan 2020-11-11 13:40:07 PST
Created attachment 413860 [details]
Patch
Comment 4 Brent Fulgham 2020-11-12 14:02:45 PST
Comment on attachment 413860 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413860&action=review

r=me

> Source/WebKit/ChangeLog:9
> +        When enabling all GPU runtime flags on iOS, there is an iokit-open sandbox violation for the IOKit class AGXDeviceUserClient

Is it a violation? Or just a violation report indicating that the access was allowed? I suspect it's the latter (i.e., we always allowed it, but we were logging in a case where we expected the access).
Comment 5 Per Arne Vollan 2020-11-12 14:04:54 PST
(In reply to Brent Fulgham from comment #4)
> Comment on attachment 413860 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413860&action=review
> 
> r=me
> 
> > Source/WebKit/ChangeLog:9
> > +        When enabling all GPU runtime flags on iOS, there is an iokit-open sandbox violation for the IOKit class AGXDeviceUserClient
> 
> Is it a violation? Or just a violation report indicating that the access was
> allowed? I suspect it's the latter (i.e., we always allowed it, but we were
> logging in a case where we expected the access).

This was actually an IOKit open violation, which caused a crash.

Thanks for reviewing!
Comment 6 EWS 2020-11-12 14:12:45 PST
Committed r269751: <https://trac.webkit.org/changeset/269751>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413860 [details].