Bug 21882

Summary: [CAIRO] Canvas radial gradient broken
Product: WebKit Reporter: Dirk Schulze <krit>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Cairo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
URL: https://developer.mozilla.org/samples/canvas-tutorial/4_10_canvas_radialgradient.html
Attachments:
Description Flags
Fixed radialGradient
darin: review+
LayoutTest darin: review+

Dirk Schulze
Reported 2008-10-24 23:03:57 PDT
The inner circle of a radial gradient is always white but shouldn't be.
Attachments
Fixed radialGradient (1.19 KB, patch)
2008-10-25 01:01 PDT, Dirk Schulze 		darin: review+
DetailsFormatted DiffDiff
LayoutTest (2.92 KB, patch)
2008-10-31 12:11 PDT, Dirk Schulze 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2008-10-25 00:35:58 PDT
fixed in one of the last revisions.
Dirk Schulze
Comment 2 2008-10-25 00:55:25 PDT
Oops! Still unfixed.
Dirk Schulze
Comment 3 2008-10-25 01:01:38 PDT
Created attachment 24672 [details] Fixed radialGradient I removed CAIRO_EXTEND_NONE in applySpreadMethod. We don't need it neither in SVG nor Canvas or CSS. And we don't need to define a default at all.
Darin Adler
Comment 4 2008-10-31 10:23:36 PDT
Comment on attachment 24672 [details] Fixed radialGradient This is the kind of patch I'd normally turn down without a regression test. Does the GTK port currently work with text-only regression tests? If so, it would be really easy to write one for this bug that uses a canvas and reads out the expected correct pixel vale, and I'd like to see it. r=me in any case
Dirk Schulze
Comment 5 2008-10-31 12:11:55 PDT
Created attachment 24806 [details] LayoutTest A LayoutTest to check the behavior.
Darin Adler
Comment 6 2008-10-31 12:20:26 PDT
Comment on attachment 24806 [details] LayoutTest Nice! r=me
Dirk Schulze
Comment 7 2008-11-11 12:14:27 PST
landed in r38302
Note You need to log in before you can comment on or make changes to this bug.