| Summary: | Define USE(LEGACY_CFNETWORK_DOWNLOADS) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, ggaren, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2020-11-11 11:47:43 PST
Created attachment 413845 [details]
Patch
Comment on attachment 413845 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413845&action=review > Source/WTF/wtf/PlatformHave.h:423 > +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101500 > +#define HAVE_MOJAVE_CFNETWORK 1 > +#endif The new name here is still a statement about an OS version ("Mojave"), so not much has changed. Also, we usually use "HAVE(X)" to mean that a feature is present, not that a bug must be worked around. This is a tricky case. Our existing macro patterns don't fit super well. I think a better fit might be one of: ENABLE(CFNETWORK_DOWNLOAD_WORKAROUNDS) USE(LEGACY_CFNETWORK_DOWNLOADS) or inverted: HAVE(MODERN_CFNETWORK_DOWNLOADS) Created attachment 413848 [details]
Patch
Comment on attachment 413848 [details]
Patch
r=me
|