Bug 218814

Summary: Define USE(LEGACY_CFNETWORK_DOWNLOADS)
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ggaren: review+

Alex Christensen
Reported 2020-11-11 11:47:43 PST
Define HAVE(MOJAVE_CFNETWORK)
Attachments
Patch (3.00 KB, patch)
2020-11-11 11:49 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.95 KB, patch)
2020-11-11 12:06 PST, Alex Christensen 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-11-11 11:49:28 PST
Created attachment 413845 [details] Patch
Geoffrey Garen
Comment 2 2020-11-11 12:01:45 PST
Comment on attachment 413845 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413845&action=review > Source/WTF/wtf/PlatformHave.h:423 > +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101500 > +#define HAVE_MOJAVE_CFNETWORK 1 > +#endif The new name here is still a statement about an OS version ("Mojave"), so not much has changed. Also, we usually use "HAVE(X)" to mean that a feature is present, not that a bug must be worked around. This is a tricky case. Our existing macro patterns don't fit super well. I think a better fit might be one of: ENABLE(CFNETWORK_DOWNLOAD_WORKAROUNDS) USE(LEGACY_CFNETWORK_DOWNLOADS) or inverted: HAVE(MODERN_CFNETWORK_DOWNLOADS)
Alex Christensen
Comment 3 2020-11-11 12:06:28 PST
Created attachment 413848 [details] Patch
Geoffrey Garen
Comment 4 2020-11-11 13:03:28 PST
Comment on attachment 413848 [details] Patch r=me
Alex Christensen
Comment 5 2020-11-11 13:10:16 PST
http://trac.webkit.org/r269700
Radar WebKit Bug Importer
Comment 6 2020-11-11 13:12:36 PST
<rdar://problem/71296010>
Note You need to log in before you can comment on or make changes to this bug.