| Summary: | Use _CFURLConnectionSetFrameworkStubs instead of DYLD_INTERPOSE on Intel Macs | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ggaren, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2020-11-11 10:20:36 PST
Created attachment 413837 [details]
Patch
Comment on attachment 413837 [details]
Patch
r=me
Committed r269697: <https://trac.webkit.org/changeset/269697> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413837 [details]. And if this breaks something, it's good to have identical behavior between Intel and Apple Silicon. I think that initially, we couldn't use CFNetworks shims on macOS because of in-process CoreMedia resource loading, but that should not be a problem any more. But isn't there a lot more icky code that can be removed now? There is, but I chose to keep it to make it easier to revert if needed. Now that I think about it, we should just remove it and revert that too if needed. |