Bug 218808

Summary: [iOS][FCR] Add new look for checkboxes
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: FormsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, changseok, cmarcelo, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, pdr, sam, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: iPhone / iPad   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 218864    
Attachments:
Description Flags
Patch
none
Patch none

Description Aditya Keerthi 2020-11-11 09:30:39 PST 
...
Comment 1 Aditya Keerthi 2020-11-11 09:31:06 PST 
<rdar://problem/71286037>
Comment 2 Aditya Keerthi 2020-11-11 09:34:15 PST 
Created attachment 413831 [details]
Patch
Comment 3 Wenson Hsieh 2020-11-12 11:45:57 PST 
Comment on attachment 413831 [details]
Patch

The change itself seems fine, but I think it would be nice to add a runtime-enabled setting for this, so that it can be tested in some capacity, in the future.
Comment 4 Sam Weinig 2020-11-15 10:58:51 PST 
Comment on attachment 413831 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413831&action=review

> Source/WebCore/css/html.css:775
> +input[type="radio"] {
> +    margin: 3px 2px;

There are other separated out input[type="radio"] and input[type="checkbox"] lower down in the file. Now that these aren't for both anymore, can we just merge these with the ones lower down?
Comment 5 Aditya Keerthi 2020-11-16 10:48:02 PST 
Created attachment 414254 [details]
Patch
Comment 6 Aditya Keerthi 2020-11-16 10:49:25 PST 
(In reply to Sam Weinig from comment #4)
> Comment on attachment 413831 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413831&action=review
> 
> > Source/WebCore/css/html.css:775
> > +input[type="radio"] {
> > +    margin: 3px 2px;
> 
> There are other separated out input[type="radio"] and input[type="checkbox"]
> lower down in the file. Now that these aren't for both anymore, can we just
> merge these with the ones lower down?

These changes are now made in a separate stylesheet, so that this feature can be turned on/off at runtime.
Comment 7 EWS 2020-11-17 10:59:36 PST 
Committed r269913: <https://trac.webkit.org/changeset/269913>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414254 [details].