Bug 218808

Summary: [iOS][FCR] Add new look for checkboxes
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: FormsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, changseok, cmarcelo, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, pdr, sam, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: iPhone / iPad   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 218864    
Attachments:
Description Flags
Patch
none
Patch none

Aditya Keerthi
Reported 2020-11-11 09:30:39 PST
...
Attachments
Patch (6.99 KB, patch)
2020-11-11 09:34 PST, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (15.87 KB, patch)
2020-11-16 10:48 PST, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2020-11-11 09:31:06 PST
<rdar://problem/71286037>
Aditya Keerthi
Comment 2 2020-11-11 09:34:15 PST
Created attachment 413831 [details] Patch
Wenson Hsieh
Comment 3 2020-11-12 11:45:57 PST
Comment on attachment 413831 [details] Patch The change itself seems fine, but I think it would be nice to add a runtime-enabled setting for this, so that it can be tested in some capacity, in the future.
Sam Weinig
Comment 4 2020-11-15 10:58:51 PST
Comment on attachment 413831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413831&action=review > Source/WebCore/css/html.css:775 > +input[type="radio"] { > + margin: 3px 2px; There are other separated out input[type="radio"] and input[type="checkbox"] lower down in the file. Now that these aren't for both anymore, can we just merge these with the ones lower down?
Aditya Keerthi
Comment 5 2020-11-16 10:48:02 PST
Created attachment 414254 [details] Patch
Aditya Keerthi
Comment 6 2020-11-16 10:49:25 PST
(In reply to Sam Weinig from comment #4) > Comment on attachment 413831 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=413831&action=review > > > Source/WebCore/css/html.css:775 > > +input[type="radio"] { > > + margin: 3px 2px; > > There are other separated out input[type="radio"] and input[type="checkbox"] > lower down in the file. Now that these aren't for both anymore, can we just > merge these with the ones lower down? These changes are now made in a separate stylesheet, so that this feature can be turned on/off at runtime.
EWS
Comment 7 2020-11-17 10:59:36 PST
Committed r269913: <https://trac.webkit.org/changeset/269913> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414254 [details].
Note You need to log in before you can comment on or make changes to this bug.