| Summary: | [build.webkit.org] Update CheckOutSource step for new buildbot | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | jbedard, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 175056 | ||||||||
| Attachments: |
|
||||||||
|
Description
Aakash Jain
2020-11-11 06:39:29 PST
Created attachment 413816 [details]
Patch
Comment on attachment 413816 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413816&action=review > Tools/CISupport/build-webkit-org/steps.py:122 > + SVN.__init__(self, **kwargs) Is there a reason we aren't using super? Created attachment 413851 [details]
Patch
(In reply to Jonathan Bedard from comment #2) > Is there a reason we aren't using super? Updated patch uses super. Committed r269699: <https://trac.webkit.org/changeset/269699> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413851 [details]. (In reply to Aakash Jain from comment #4) > (In reply to Jonathan Bedard from comment #2) > > Is there a reason we aren't using super? > Updated patch uses super. Actually unit-test (and buildbot checkconfig) on old buildbot/python fails when using super on this class (old-style class) with following error (e.g.: https://ews-build.webkit.org/#/builders/20/builds/34537). File "steps.py", line 145, in __init__ super(CheckOutSource, self).__init__(**kwargs) TypeError: super() argument 1 must be type, not classobj This is because this SVN class in old buildbot is old-style class. See: https://stackoverflow.com/questions/1713038/super-fails-with-error-typeerror-argument-1-must-be-type-not-classobj-when Committed r269731: <https://trac.webkit.org/changeset/269731> |