| Summary: | "files" string for multifile uploads needs to be localized | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
| Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | adele, sullivan | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Mac | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Sam Weinig
2008-10-24 21:53:58 PDT
Created attachment 24726 [details]
patch
This also includes changes to update-webkit-localizable-strings since the script wasn't working with the Mac platform directory structure
Comment on attachment 24726 [details]
patch
r=me
Comment on attachment 24726 [details]
patch
This doesn't seem right to me. You can't localize a string like "8 files" by localizing the word "files" and appending it to "8 ". You need to localize the entire string, with a wildcard for the number, like "%d files".
Created attachment 24735 [details]
updated patch
Comment on attachment 24735 [details]
updated patch
I suggest a FIXME for the GTK and Wx ports that says something like "// FIXME: This should really be localizing the entire string with a wildcard for the count"
Committed revision 37949. |