Bug 21880

Summary: "files" string for multifile uploads needs to be localized
Product: WebKit Reporter: Sam Weinig <sam>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, sullivan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
patch
sullivan: review-
updated patch sullivan: review+

Sam Weinig
Reported 2008-10-24 21:53:58 PDT
The string we use when you select multiple files for upload needs locatlization
Attachments
patch (38.02 KB, patch)
2008-10-28 13:25 PDT, Adele Peterson 		sullivan: review-
DetailsFormatted DiffDiff
updated patch (9.73 KB, patch)
2008-10-28 16:15 PDT, Adele Peterson 		sullivan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adele Peterson
Comment 1 2008-10-28 13:25:36 PDT
Created attachment 24726 [details] patch This also includes changes to update-webkit-localizable-strings since the script wasn't working with the Mac platform directory structure
Sam Weinig
Comment 2 2008-10-28 13:32:02 PDT
Comment on attachment 24726 [details] patch r=me
John Sullivan
Comment 3 2008-10-28 13:40:51 PDT
Comment on attachment 24726 [details] patch This doesn't seem right to me. You can't localize a string like "8 files" by localizing the word "files" and appending it to "8 ". You need to localize the entire string, with a wildcard for the number, like "%d files".
Adele Peterson
Comment 4 2008-10-28 16:15:16 PDT
Created attachment 24735 [details] updated patch
John Sullivan
Comment 5 2008-10-28 16:32:34 PDT
Comment on attachment 24735 [details] updated patch I suggest a FIXME for the GTK and Wx ports that says something like "// FIXME: This should really be localizing the entire string with a wildcard for the count"
Adele Peterson
Comment 6 2008-10-28 16:36:54 PDT
Committed revision 37949.
Note You need to log in before you can comment on or make changes to this bug.