| Summary: | Implementation for AXIsolatedObject methods that return a VisiblePositionRange. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||
| Component: | New Bugs | Assignee: | Andres Gonzalez <andresg_22> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Andres Gonzalez
2020-11-10 19:31:24 PST
Created attachment 413763 [details]
Patch
Comment on attachment 413763 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413763&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:1181 > + return axObject ? axObject->visiblePositionRange() : VisiblePositionRange(); For the default values I think you can just return { }; now (In reply to chris fleizach from comment #2) > Comment on attachment 413763 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=413763&action=review > > > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:1181 > > + return axObject ? axObject->visiblePositionRange() : VisiblePositionRange(); > > For the default values I think you can just return { }; now not with ? : operators: error: initializer list cannot be used on the right hand side of operator ':' Committed r269692: <https://trac.webkit.org/changeset/269692> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413763 [details]. |