Bug 218781

Summary: [JSC] wasm fault trampoline should be C code since it is tagged as CFunctionPtr
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch keith_miller: review+

Description Yusuke Suzuki 2020-11-10 19:18:53 PST 
[JSC] wasm fault trampoline should be C code since it is tagged as CFunctionPtr
Comment 1 Yusuke Suzuki 2020-11-10 19:20:12 PST 
Created attachment 413762 [details]
Patch
Comment 2 Mark Lam 2020-11-11 09:58:40 PST 
Comment on attachment 413762 [details]
Patch

In AirIRGenerator::AirIRGenerator(), for the MemoryMode::Signaling case, it checks if (UNLIKELY(!Thunks::singleton().stub(throwExceptionFromWasmThunkGenerator))).  Is that still needed, or is it now obsolete?

Ditto for B3IRGenerator::B3IRGenerator().
Comment 3 Yusuke Suzuki 2020-11-11 11:23:39 PST 
(In reply to Mark Lam from comment #2)
> Comment on attachment 413762 [details]
> Patch
> 
> In AirIRGenerator::AirIRGenerator(), for the MemoryMode::Signaling case, it
> checks if
> (UNLIKELY(!Thunks::singleton().stub(throwExceptionFromWasmThunkGenerator))).
> Is that still needed, or is it now obsolete?
> 
> Ditto for B3IRGenerator::B3IRGenerator().

Right! This is not necessary. Removed.
Comment 4 Yusuke Suzuki 2020-11-11 11:51:26 PST 
Committed r269694: <https://trac.webkit.org/changeset/269694>
Comment 5 Radar WebKit Bug Importer 2020-11-11 11:52:17 PST 
<rdar://problem/71292659>