Bug 218772

Summary: Make PlatformWheelEventPhase an enum class
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, esprehn+autocc, ews-watchlist, fred.wang, jamesr, kangil.han, luiz, simon.fraser, thorton, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Simon Fraser (smfr)
Reported 2020-11-10 13:43:16 PST
Make PlatformWheelEventPhase an enum class
Attachments
Patch (38.71 KB, patch)
2020-11-10 13:45 PST, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-11-10 13:45:00 PST
Created attachment 413733 [details] Patch
Tim Horton
Comment 2 2020-11-10 13:50:39 PST
Comment on attachment 413733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413733&action=review > Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:-176 > - if ([event momentumPhase] & NSEventPhaseBegan) Weird! > Source/WebCore/platform/mac/ScrollAnimatorMac.mm:1249 > +// FIXME: Need to ensure we get PlatformWheelEventPhase::Ended. While you're here, indent the comment.
Simon Fraser (smfr)
Comment 3 2020-11-10 16:38:55 PST
https://trac.webkit.org/r269659
Radar WebKit Bug Importer
Comment 4 2020-11-10 16:39:28 PST
<rdar://problem/71260959>
Note You need to log in before you can comment on or make changes to this bug.