Bug 218772

Summary: Make PlatformWheelEventPhase an enum class
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, esprehn+autocc, ews-watchlist, fred.wang, jamesr, kangil.han, luiz, simon.fraser, thorton, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Simon Fraser (smfr) 2020-11-10 13:43:16 PST
Make PlatformWheelEventPhase an enum class
Comment 1 Simon Fraser (smfr) 2020-11-10 13:45:00 PST
Created attachment 413733 [details]
Patch
Comment 2 Tim Horton 2020-11-10 13:50:39 PST
Comment on attachment 413733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413733&action=review

> Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:-176
> -    if ([event momentumPhase] & NSEventPhaseBegan)

Weird!

> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:1249
> +// FIXME: Need to ensure we get PlatformWheelEventPhase::Ended.

While you're here, indent the comment.
Comment 3 Simon Fraser (smfr) 2020-11-10 16:38:55 PST
https://trac.webkit.org/r269659
Comment 4 Radar WebKit Bug Importer 2020-11-10 16:39:28 PST
<rdar://problem/71260959>