Bug 218771

Summary: [macCatalyst] Fix various build breaks
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: New BugsAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, mifenton, philipj, ryanhaddad, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Said Abou-Hallawa 2020-11-10 13:30:37 PST 
For example r269614 caused the following compilation error:

./editing/cocoa/DictionaryLookup.mm:249:31: error: no viable conversion from 'RefPtr<WebCore::NativeImage>' to 'RetainPtr<CGImageRef>' (aka 'RetainPtr<CGImage *>')
Comment 1 Said Abou-Hallawa 2020-11-10 13:32:06 PST 
Created attachment 413730 [details]
Patch
Comment 2 Tim Horton 2020-11-10 14:06:17 PST 
Comment on attachment 413730 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413730&action=review

> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:2067
> -- (void)setAVKitEnabled:(bool)flag
> +- (void)setAVKitEnabled:(BOOL)flag

What does the header say??
Comment 3 Said Abou-Hallawa 2020-11-10 14:29:49 PST 
Comment on attachment 413730 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413730&action=review

>> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:2067
>> +- (void)setAVKitEnabled:(BOOL)flag
> 
> What does the header say??

In Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h, there is this definition:

@property (nonatomic, getter=avKitEnabled) BOOL AVKitEnabled;
Comment 4 Ryan Haddad 2020-11-10 14:58:28 PST 
rdar://71251933
Comment 5 EWS 2020-11-10 14:58:43 PST 
Committed r269648: <https://trac.webkit.org/changeset/269648>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413730 [details].