Bug 218771 - [macCatalyst] Fix various build breaks
Summary: [macCatalyst] Fix various build breaks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-10 13:30 PST by Said Abou-Hallawa
Modified: 2020-11-10 14:58 PST (History)
10 users (show)

See Also:

Attachments
Patch (5.98 KB, patch)
2020-11-10 13:32 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2020-11-10 13:30:37 PST 
For example r269614 caused the following compilation error:

./editing/cocoa/DictionaryLookup.mm:249:31: error: no viable conversion from 'RefPtr<WebCore::NativeImage>' to 'RetainPtr<CGImageRef>' (aka 'RetainPtr<CGImage *>')
Comment 1 Said Abou-Hallawa 2020-11-10 13:32:06 PST 
Created attachment 413730 [details]
Patch
Comment 2 Tim Horton 2020-11-10 14:06:17 PST 
Comment on attachment 413730 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413730&action=review

> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:2067
> -- (void)setAVKitEnabled:(bool)flag
> +- (void)setAVKitEnabled:(BOOL)flag

What does the header say??
Comment 3 Said Abou-Hallawa 2020-11-10 14:29:49 PST 
Comment on attachment 413730 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413730&action=review

>> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:2067
>> +- (void)setAVKitEnabled:(BOOL)flag
> 
> What does the header say??

In Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h, there is this definition:

@property (nonatomic, getter=avKitEnabled) BOOL AVKitEnabled;
Comment 4 Ryan Haddad 2020-11-10 14:58:28 PST 
rdar://71251933
Comment 5 EWS 2020-11-10 14:58:43 PST 
Committed r269648: <https://trac.webkit.org/changeset/269648>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413730 [details].