Bug 218767

Summary: [LFC][IFC] Add support for replaced element baseline
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description zalan 2020-11-10 12:20:00 PST
as replaced elements can have set baselines
Comment 1 zalan 2020-11-10 12:21:31 PST
Created attachment 413722 [details]
Patch
Comment 2 Antti Koivisto 2020-11-10 12:35:11 PST
Comment on attachment 413722 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413722&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:265
> +            } else if (layoutBox.isReplacedBox())
> +                ascent = downcast<ReplacedBox>(layoutBox).baseline().valueOr(marginBoxHeight);

Should this have a comment that this is an extensions, not something found from spec?
Comment 3 zalan 2020-11-10 13:09:01 PST
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 413722 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413722&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:265
> > +            } else if (layoutBox.isReplacedBox())
> > +                ascent = downcast<ReplacedBox>(layoutBox).baseline().valueOr(marginBoxHeight);
> 
> Should this have a comment that this is an extensions, not something found
> from spec?
The spec talks about atomic inline box in general in the context of baseline set, so I assume that applies to replaced inline boxes as well.
Comment 4 EWS 2020-11-10 13:28:01 PST
Committed r269645: <https://trac.webkit.org/changeset/269645>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413722 [details].
Comment 5 Radar WebKit Bug Importer 2020-11-10 13:29:15 PST
<rdar://problem/71252659>