Summary: | [css-flex] Better naming from some methods | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||||
Component: | New Bugs | Assignee: | Sergio Villar Senin <svillar> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | changseok, darin, dbates, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, rego, svillar, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Sergio Villar Senin
2020-11-10 04:17:24 PST
Created attachment 413684 [details]
Patch
Comment on attachment 413684 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413684&action=review > Source/WebCore/rendering/RenderFlexibleBox.cpp:390 > { I'm not totally sure about this change. Somehow, we are using a different concept here; flow vs size. What about mainAxisFlowIsChildBlockFlow using the concepts used in the CSS Logical Prooperties [1] about the flow-relative dimensions, based on the Writing Modes terminology [2] ]1] https://www.w3.org/TR/css-logical-1/#directional-keywords [2] https://www.w3.org/TR/css-writing-modes-4/#block-flow Comment on attachment 413684 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413684&action=review >> Source/WebCore/rendering/RenderFlexibleBox.cpp:390 >> { > > I'm not totally sure about this change. Somehow, we are using a different concept here; flow vs size. > > What about mainAxisFlowIsChildBlockFlow using the concepts used in the CSS Logical Prooperties [1] about the flow-relative dimensions, based on the Writing Modes terminology [2] > > ]1] https://www.w3.org/TR/css-logical-1/#directional-keywords > [2] https://www.w3.org/TR/css-writing-modes-4/#block-flow Makes sense. What about mainAxisIsChildInlineAxis() ? Note that I'm changing the equality bellow, so we no longer check the block but the inline direction. Comment on attachment 413684 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413684&action=review >>> Source/WebCore/rendering/RenderFlexibleBox.cpp:390 >>> { >> >> I'm not totally sure about this change. Somehow, we are using a different concept here; flow vs size. >> >> What about mainAxisFlowIsChildBlockFlow using the concepts used in the CSS Logical Prooperties [1] about the flow-relative dimensions, based on the Writing Modes terminology [2] >> >> ]1] https://www.w3.org/TR/css-logical-1/#directional-keywords >> [2] https://www.w3.org/TR/css-writing-modes-4/#block-flow > > Makes sense. What about mainAxisIsChildInlineAxis() ? Note that I'm changing the equality bellow, so we no longer check the block but the inline direction. OK Created attachment 413797 [details]
Patch
Committed r269840: <https://trac.webkit.org/changeset/269840> |