Bug 218728

Summary: Stop using objc_autoreleasePool{Push, Pop} in RunLoop observers
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, thorton
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
thorton: review+
Patch for landing
ews-feeder: commit-queue-
Patch for landing none

Description Geoffrey Garen 2020-11-09 16:11:20 PST 
Stop using deprecated objc_autoreleasePool{Push, Pop}
Comment 1 Geoffrey Garen 2020-11-09 16:13:38 PST 
rdar://problem/67283410
Comment 2 Geoffrey Garen 2020-11-09 16:29:54 PST 
Created attachment 413642 [details]
Patch
Comment 3 Geoffrey Garen 2020-11-10 11:34:28 PST 
Created attachment 413719 [details]
Patch
Comment 4 Chris Dumez 2020-11-10 13:05:58 PST 
Comment on attachment 413719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413719&action=review

> Source/WebCore/platform/ios/wak/WebCoreThread.mm:60
> +static inline bool _CFRunLoopSetPerCalloutAutoreleasepoolEnabled(BOOL)

Don't we usually do a forward-declaration for those things instead of providing our own implementation? Like we do in all our *SPI.h headers?
Comment 5 Tim Horton 2020-11-10 13:30:00 PST 
Comment on attachment 413719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413719&action=review

>> Source/WebCore/platform/ios/wak/WebCoreThread.mm:60
>> +static inline bool _CFRunLoopSetPerCalloutAutoreleasepoolEnabled(BOOL)
> 
> Don't we usually do a forward-declaration for those things instead of providing our own implementation? Like we do in all our *SPI.h headers?

Yes (and technically it should be /in/ a SPI header... see CFBundleSPI or CFStringSPI, and make a CFRunLoopSPI).
Comment 6 Geoffrey Garen 2020-11-10 13:45:24 PST 
Created attachment 413734 [details]
Patch
Comment 7 Tim Horton 2020-11-10 14:39:26 PST 
Comment on attachment 413734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413734&action=review

> Source/WTF/wtf/spi/cf/CFRunLoopSPI.h:2
> + * Copyright (C) 2017 Apple Inc.  All rights reserved.

If only
Comment 8 Geoffrey Garen 2020-11-10 15:14:38 PST 
Created attachment 413746 [details]
Patch for landing
Comment 9 EWS 2020-11-10 15:15:26 PST 
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Comment 10 Geoffrey Garen 2020-11-10 15:23:04 PST 
Created attachment 413748 [details]
Patch for landing
Comment 11 EWS 2020-11-10 15:53:33 PST 
Committed r269658: <https://trac.webkit.org/changeset/269658>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413748 [details].