Bug 218728

Summary:

Stop using objc_autoreleasePool{Push, Pop} in RunLoop observers

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

New Bugs

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, ews-watchlist, thorton

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	thorton: review+
Patch for landing	ews-feeder: commit-queue-
Patch for landing	none

Geoffrey Garen

Reported 2020-11-09 16:11:20 PST

Stop using deprecated objc_autoreleasePool{Push, Pop}

Attachments
Patch (3.37 KB, patch) 2020-11-09 16:29 PST, Geoffrey Garen	no flags	Details Formatted Diff Diff
Patch (3.75 KB, patch) 2020-11-10 11:34 PST, Geoffrey Garen	no flags	Details Formatted Diff Diff
Patch (7.16 KB, patch) 2020-11-10 13:45 PST, Geoffrey Garen	thorton: review+	Details Formatted Diff Diff
Patch for landing (7.16 KB, patch) 2020-11-10 15:14 PST, Geoffrey Garen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (7.16 KB, patch) 2020-11-10 15:23 PST, Geoffrey Garen	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Geoffrey Garen

Comment 1 2020-11-09 16:13:38 PST

rdar://problem/67283410

Geoffrey Garen

Comment 2 2020-11-09 16:29:54 PST

Created attachment 413642 [details] Patch

Geoffrey Garen

Comment 3 2020-11-10 11:34:28 PST

Created attachment 413719 [details] Patch

Chris Dumez

Comment 4 2020-11-10 13:05:58 PST

Comment on attachment 413719 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413719&action=review > Source/WebCore/platform/ios/wak/WebCoreThread.mm:60 > +static inline bool _CFRunLoopSetPerCalloutAutoreleasepoolEnabled(BOOL) Don't we usually do a forward-declaration for those things instead of providing our own implementation? Like we do in all our *SPI.h headers?

Tim Horton

Comment 5 2020-11-10 13:30:00 PST

Comment on attachment 413719 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413719&action=review >> Source/WebCore/platform/ios/wak/WebCoreThread.mm:60 >> +static inline bool _CFRunLoopSetPerCalloutAutoreleasepoolEnabled(BOOL) > > Don't we usually do a forward-declaration for those things instead of providing our own implementation? Like we do in all our *SPI.h headers? Yes (and technically it should be /in/ a SPI header... see CFBundleSPI or CFStringSPI, and make a CFRunLoopSPI).

Geoffrey Garen

Comment 6 2020-11-10 13:45:24 PST

Created attachment 413734 [details] Patch

Tim Horton

Comment 7 2020-11-10 14:39:26 PST

Comment on attachment 413734 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413734&action=review > Source/WTF/wtf/spi/cf/CFRunLoopSPI.h:2 > + * Copyright (C) 2017 Apple Inc. All rights reserved. If only

Geoffrey Garen

Comment 8 2020-11-10 15:14:38 PST

Created attachment 413746 [details] Patch for landing

EWS

Comment 9 2020-11-10 15:15:26 PST

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Geoffrey Garen

Comment 10 2020-11-10 15:23:04 PST

Created attachment 413748 [details] Patch for landing

EWS

Comment 11 2020-11-10 15:53:33 PST

Committed r269658: <https://trac.webkit.org/changeset/269658> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413748 [details].

Note You need to log in before you can comment on or make changes to this bug.